-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Remove Kite completion provider code #21249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @jsbautista ! I left a comment regarding another entry to remove from the NOTICE.txt
related with pybloom_pyqt
utils code (which also is missing to be removed).
Besides that, I think we need to update the docstrings/comments for the completions plugin at:
- https://github.com/jsbautista/spyder/blob/f79aafd044be814db8b77985188d8c15fb8a59e7/spyder/plugins/completion/plugin.py#L67 (remove kite mention)
- https://github.com/jsbautista/spyder/blob/f79aafd044be814db8b77985188d8c15fb8a59e7/spyder/plugins/completion/plugin.py#L1234 (remove kite mention and just put providers in general)
Also, I'm not totally sure what we should do with the entry point validation for Kite at https://github.com/jsbautista/spyder/blob/f79aafd044be814db8b77985188d8c15fb8a59e7/spyder/plugins/completion/plugin.py#L239-L244
What do you think about that last point @ccordoba12 ? Should we keep the entry point validation for Kite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista ! I did a small suggestion for text inside a comment and I think the only missing element to check is what to do about the entry point validation for Kite at https://github.com/jsbautista/spyder/blob/f79aafd044be814db8b77985188d8c15fb8a59e7/spyder/plugins/completion/plugin.py#L239-L244
What do you think about that @ccordoba12 ?
Other than that this LGTM 👍
Co-authored-by: Daniel Althviz Moré <[email protected]>
At first glance, this looks good to me. Thanks @jsbautista for your work on it! The only thing missing is to allow the external Kite code completion plugin to be loaded in Spyder. I don't remember where that's forbidden right now, but you can take a look at it with @dalthviz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista and @dalthviz for your work on this!
Description of Changes
Remove kite from the Spyder main repository
Related to spyder-ide/kite-provider#1
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista