Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove Kite completion provider code #21249

Merged
merged 19 commits into from
Sep 11, 2023

Conversation

jsbautista
Copy link
Contributor

@jsbautista jsbautista commented Aug 12, 2023

Description of Changes

Remove kite from the Spyder main repository

Related to spyder-ide/kite-provider#1

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

@dalthviz dalthviz added this to the v6.0alpha2 milestone Aug 14, 2023
@ccordoba12 ccordoba12 modified the milestones: v6.0alpha2, v6.0alpha3 Aug 15, 2023
@dalthviz dalthviz self-requested a review August 28, 2023 19:35
@dalthviz dalthviz changed the title [WIP] PR: Delete Kite PR: Delete Kite Aug 28, 2023
@dalthviz dalthviz changed the title PR: Delete Kite PR: Remove Kite completion provider code Aug 29, 2023
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here @jsbautista ! I left a comment regarding another entry to remove from the NOTICE.txt related with pybloom_pyqt utils code (which also is missing to be removed).

Besides that, I think we need to update the docstrings/comments for the completions plugin at:

Also, I'm not totally sure what we should do with the entry point validation for Kite at https://github.com/jsbautista/spyder/blob/f79aafd044be814db8b77985188d8c15fb8a59e7/spyder/plugins/completion/plugin.py#L239-L244

What do you think about that last point @ccordoba12 ? Should we keep the entry point validation for Kite?

NOTICE.txt Show resolved Hide resolved
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista ! I did a small suggestion for text inside a comment and I think the only missing element to check is what to do about the entry point validation for Kite at https://github.com/jsbautista/spyder/blob/f79aafd044be814db8b77985188d8c15fb8a59e7/spyder/plugins/completion/plugin.py#L239-L244

What do you think about that @ccordoba12 ?

Other than that this LGTM 👍

spyder/plugins/completion/plugin.py Outdated Show resolved Hide resolved
@ccordoba12
Copy link
Member

At first glance, this looks good to me. Thanks @jsbautista for your work on it!

The only thing missing is to allow the external Kite code completion plugin to be loaded in Spyder. I don't remember where that's forbidden right now, but you can take a look at it with @dalthviz.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista and @dalthviz for your work on this!

@ccordoba12 ccordoba12 merged commit 0c14204 into spyder-ide:master Sep 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants