PR: Initial Kite provider code from the Spyder main repo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dalthviz, I think this PR is ready for the initial merge |
dalthviz
changed the title
dalthviz
changed the title
dalthviz
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Thanks for the work here @jsbautista ! Left some initial comments/suggestions. In general a couple of missing things to remove and some changes to the README to add info on how to install the provider. I'm pending doing a local check with the latest changes but other than that this LGTM 👍
Co-authored-by: Daniel Althviz Moré <[email protected]>
Co-authored-by: Daniel Althviz Moré <[email protected]>
dalthviz
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Thanks for applying the last review changes @jsbautista ! I left some more suggestions. After you apply those I will merge this 👍
Co-authored-by: Daniel Althviz Moré <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Move kite from the Spyder main repository. Here we remove some code that is not necessary/would not work anymore like:
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista