Skip to content

PR: Remove Kite completion provider code #21249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/scripts/modules_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ for f in spyder/*/*/*/*.py; do
if [[ $f == spyder/plugins/editor/panels/__init__.py ]]; then
continue
fi
if [[ $f == spyder/utils/external/pybloom_pyqt/*.py ]]; then
continue
fi
python "$f"
if [ $? -ne 0 ]; then
exit 1
Expand Down
74 changes: 0 additions & 74 deletions NOTICE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1479,37 +1479,6 @@ spyder/images/light/file_type_tex.svg
-------------------------------------------------------------------------------


Icons for Kite Completions Plugin
---------------------------------


Copyright (c) 2019 Kite


Author: Kite | https://kite.com
Site: https://kite.com
Source: https://kite.com
License: Creative Commons Attribution 4.0 International
https://creativecommons.org/licenses/by/4.0/


Licensed under the terms of the Creative Commons Attribution International 4.0.


See below for the full text of the Creative Commons Attribution International 4.0 License.


Files covered:

spyder/images/dark/kite.svg
spyder/images/kite/kite_copilot.png
spyder/images/light/kite.svg


===============================================================================



Plugin Assets
=============

Expand Down Expand Up @@ -1550,49 +1519,6 @@ spyder/plugins/help/utils/static/images/up_arrow_disabled.png



pyqt-bloomfilter 3.0.0
-------------------------------------------------------------------------


Copyright (c) 2011 Jay Baird and Bob Ippolito
Copyright (c) 2019 - Spyder Project Contributors (see AUTHORS.txt)


Author: Jay Baird and Bob Ippolito
Source: https://github.com/kiteco/pyqt-bloomfilter
License: MIT (expat)
https://opensource.org/licenses/MIT

No modifications made.


pyqt-bloomfilter is used in Spyder under the terms of the MIT.
See below for the full text of the MIT.

spyder/utils/external/pybloom_pyqt is used in Spyder
to implement fast lookup of the availability of Kite completions.

See below for the full text of the MIT (expat) license.

The current pyqt-bloomfilter license can be viewed at:
https://github.com/kiteco/pyqt-bloomfilter/blob/master/LICENSE.txt

The current version of the original file[s] can be viewed at:
https://github.com/kiteco/pyqt-bloomfilter


Files covered:

spyder/utils/external/pybloom_pyqt/__init__.py
spyder/utils/external/pybloom_pyqt/pybloom.py
spyder/utils/external/pybloom_pyqt/utils.py


-------------------------------------------------------------------------------




Full License Text
=================

Expand Down
3 changes: 0 additions & 3 deletions spyder/app/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,6 @@ def main_window(request, tmpdir, qtbot):
# fails
super_processEvents = QApplication.processEvents

# Disable Kite provider
CONF.set('completions', 'enabled_providers', {'kite': False})

# Don't show tours message
CONF.set('tours', 'show_tour_message', False)

Expand Down
1 change: 0 additions & 1 deletion spyder/images/dark/kite.svg

This file was deleted.

Binary file removed spyder/images/kite/kite_completions.png
Binary file not shown.
Binary file removed spyder/images/kite/kite_copilot.png
Binary file not shown.
1 change: 0 additions & 1 deletion spyder/images/light/kite.svg

This file was deleted.

10 changes: 2 additions & 8 deletions spyder/plugins/completion/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class CompletionPlugin(SpyderPluginV2):
set of :class:`SpyderCompletionProvider` instances that are discovered
and registered via entrypoints.

This plugin can assume that `fallback`, `snippets`, `lsp` and `kite`
This plugin can assume that `fallback`, `snippets` and `lsp`
completion providers are available, since they are included as part of
Spyder.
"""
Expand Down Expand Up @@ -236,12 +236,6 @@ def __init__(self, parent, configuration=None):
# entrypoints
for entry_point in iter_entry_points(COMPLETION_ENTRYPOINT):
try:
# This absolutely ensures that the Kite provider won't be
# loaded. For instance, it can happen when you have an older
# Spyder version installed, but you're running it with
# bootstrap.
if 'kite' in entry_point.name:
continue
logger.debug(f'Loading entry point: {entry_point}')
Provider = entry_point.resolve()
self._instantiate_and_register_provider(Provider)
Expand Down Expand Up @@ -1231,7 +1225,7 @@ def match_and_reply(self, req_id: int):
else:
# Any empty response will be discarded and the completion
# loop will wait for the next non-empty response.
# This should fix the scenario where Kite does not have a
# This should fix the scenario where a provider does not have a
# response for a non-aggregated request but the LSP does.
any_nonempty = any(request_responses['sources'].get(source)
for source in sorted_providers)
Expand Down
53 changes: 0 additions & 53 deletions spyder/plugins/completion/providers/kite/__init__.py

This file was deleted.

29 changes: 0 additions & 29 deletions spyder/plugins/completion/providers/kite/bloomfilter/__init__.py

This file was deleted.

Binary file not shown.
Loading