PR: Fix regression in FORCE_QT_API behavior from merging PySide6 support#276
Conversation
tlambert03
commented
Nov 8, 2021
CAM-Gerlach
approved these changes
Nov 8, 2021
Member
There was a problem hiding this comment.
Good catch, @tlambert03 , thanks! LGTM, aside from the second (EDIT: and third) commit needing a fixup (and only if @dalthviz would rather not squash-merge it).
I was going to comment on the introduced typo (and clarify the comment a bit), but you fixed the former faster than I could do so, heh.
tlambert03
commented
Nov 8, 2021
Member
|
NB @dalthviz , the second and third commit either needs a |
dalthviz
approved these changes
Nov 8, 2021
Member
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @tlambert03 for noticing this and submitting a fix! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#225 somehow reverted the fix for the broken
FORCE_QT_APIthat was fixed in #230. presumably a merge fail... not sure if there are otherson current master (this pretty much destroys environments with multiple Qt backends)