PR: Add Contributing Guide based on other Spyder projects#277
Merged
dalthviz merged 2 commits intospyder-ide:masterfrom Nov 10, 2021
CAM-Gerlach:add-contributing-guide
Merged
PR: Add Contributing Guide based on other Spyder projects#277dalthviz merged 2 commits intospyder-ide:masterfrom CAM-Gerlach:add-contributing-guide
dalthviz merged 2 commits intospyder-ide:masterfrom
CAM-Gerlach:add-contributing-guide
Conversation
dalthviz
reviewed
Nov 8, 2021
Member
dalthviz
left a comment
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @CAM-Gerlach for the help with this! Left some comments/suggestions, otherwise LGTM 👍
dalthviz
reviewed
Nov 9, 2021
Co-authored-by: Daniel Althviz Moré <d.althviz10@uniandes.edu.co>
dalthviz
approved these changes
Nov 10, 2021
Member
dalthviz
left a comment
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @CAM-Gerlach ! LGTM 👍
Member
Author
|
Thanks @dalthviz ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Contributing Guide based on the one for
spyder-docs-sphinx-theme, which you both previously reviewed and provided a number of helpful suggestions and improvements on (all of which are, of course, incorporated here), and also mirroring where applicable the versions in the website, docs, theme and other repos.In addition to find-replacing the QtPy project and repo names and eliminating content that isn't relevant, a number of other sections tailored to the specifics of QtPy were added, including:
Running the Testssection (per Add documentation for how to run tests #66 )master, aside from critical/security fixes or when otherwise directed)Resolve #66
Part of #85