PR: Fix imported modules logic if 'FORCE_QT_API' is empty

[hiaselhans]

As mentioned in #222 i stumbled across this.

before:

after (expected behaviour):

It seems obvious to me and i spare further explination.

[CAM-Gerlach]

This does seem like the intended behavior based on the comment, though I'm not sure why it wasn't caught in the original PR #194 . This will affect backward compatibility. however, but no way around that due to how it was implemented previously.

@JasonGilholme any feedback here?

[hiaselhans]

thanks @CAM-Gerlach for taking care of this quite fundamental package.

How can i trigger the gh-actions-based checks?
Maybe i should add a test? :)

[hiaselhans]

Hi @CAM-Gerlach

any progress on the maintainers issue?
Qtpy seems to be a core module used in quite a few projects, even in Spyder and being left without maintainer.

looking at #229 #233 #225 and others i feel like many other packages are waiting for qtpy to bump its version, drop qt4 and support pyside6

[hiaselhans]

@andfoy @ccordoba12

could you please pay a little attention on this base package too? Or delegate work to a new maintainer.
I see quite some community action here and every now and then i get notifications of devs encountering the same issue.

[hiaselhans]

another month, another reminder @andfoy @ccordoba12 ;)

[dalthviz]

Hi @hiaselhans could you remove the unrelated commits from this PR? Or if is better for you, maybe we can help you with that? Let us know :)

[hiaselhans]

Hi @dalthviz !

great to see some news here…
I think those came from rebasing. If i open a new pr from the same branch they shouldnt be visible, right…?

[dalthviz]

Thank you for the fast response @hiaselhans ! I think that now these commits are in the branch so if you create a new PR that uses the same branch will lead still to seeing them. What you could try is to create a new clean branch (using as base an updated master branch version) and then cherry pick the commits here that are actually related to the import logic for FORCE_QT_API (which I think is commit 3f676d9) or try to remove the commits that are unrelated to the import logic for FORCE_QT_API. Let us know if you need any help :)

[hiaselhans]

Ok i think i can do it later today :)

[hiaselhans]

hi @dalthviz

i removed all commits but that one :)
hope it is fine like that. Good to see some progress here!

[dalthviz]

Thanks @hiaselhans ! LGTM 👍