Improve __init__.py.#237
Closed
UmbralReaper wants to merge 0 commit intospyder-ide:masterfrom
UmbralReaper:import-logic
Closed
Improve __init__.py.#237UmbralReaper wants to merge 0 commit intospyder-ide:masterfrom UmbralReaper:import-logic
UmbralReaper wants to merge 0 commit intospyder-ide:masterfrom
UmbralReaper:import-logic
Conversation
Contributor
avalentino
reviewed
Oct 11, 2021
qtpy/__init__.py
Outdated
|
|
||
| # Detecting if a binding was specified by the user | ||
| binding_specified = QT_API in os.environ | ||
| binding_specified = os.environ[QT_API] is not None |
Contributor
There was a problem hiding this comment.
- binding_specified = os.environ[QT_API] is not None
+ binding_specified = os.environ.get(QT_API) is not None
Author
|
Most of the changes I wanted to merge have already been merged during the process of removing PyQt4 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to clean up the login in
__init__.py. It fixes #230, and also performs a general cleanup of the file. I'll also attempt to merge some of the functionality from #156 into this.The biggest change currently is that if the user specifies a specific
QT_API, and it is not found, aPythonQtInvalidBindingRuntimeErrorwil be raised instead of aRuntimeWarning.