Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 20, 2021

This PR cleans up PSA: removes splunk-appinspect dependency, cleans documentation and uploads coverage results to codecov.io

I have tested PSA without splunk-appinspect in couple of add-ons and it works.

Closes #475

Artem Rys and others added 7 commits December 16, 2021 14:53
* ci: apply concurrency for build-test-release job
* refactor: use conf-parser in EventtypeParser instead of splunk-appinspect
* refactor: use conf-parser in SavedsearchesParser instead of splunk-appinspect
* refactor: use conf-parser in TransformsParser instead of splunk-appinspect
* refactor: use conf-parser in PropsParser instead of splunk-appinspect
* refactor: remove splunk-appinspect from AddonParser
* docs: remove splunk-appinspect mentions from PropsParser
* test: empty stanza in savedsearches.conf
* refactor: use new EventtypeParser in cim_field_report
* refactor: use conf-parser in eventgen.conf parser
* chore: remove create_new_eventgen
* feat: remove splunk_appinspect dependency
* chore: rename to pytest_splunk_addon_data
* chore: style the docs pagee
* ci: restructure tests
* ci: not run tests with Splunk 8.0
* refactor: move some public methods to be private
* ci: add debug-statements to pre-commit configuration
# [1.12.0-beta.1](v1.11.3...v1.12.0-beta.1) (2021-12-16)

### Features

* remove splunk-appinspect dependency ([#464](#464)) ([206c7d1](206c7d1))
# [1.12.0-beta.2](v1.12.0-beta.1...v1.12.0-beta.2) (2021-12-17)

### Bug Fixes

* RFC3164 regex updated ([#479](#479)) ([35ff77f](35ff77f))
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2021

CLA Assistant Lite bot: All contributors have NOT signed the COC Document


I have read the Code of Conduct and I hereby accept the Terms


1 out of 2 committers have signed the CLA.
✅ @arys-splunk
@semantic-release-bot
You can retrigger this bot by commenting recheck in this Pull Request

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@6914529). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage        ?   95.06%           
=======================================
  Files           ?       49           
  Lines           ?     2612           
  Branches        ?        0           
=======================================
  Hits            ?     2483           
  Misses          ?      129           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6914529...c8ac474. Read the comment docs.

@ghost ghost marked this pull request as ready for review December 22, 2021 11:05
dependabot bot and others added 4 commits December 23, 2021 12:20
Bumps [jsonschema](https://github.com/Julian/jsonschema) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/Julian/jsonschema/releases)
- [Changelog](https://github.com/Julian/jsonschema/blob/main/CHANGELOG.rst)
- [Commits](python-jsonschema/jsonschema@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: jsonschema
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jsonschema](https://github.com/Julian/jsonschema) from 4.3.1 to 4.3.2.
- [Release notes](https://github.com/Julian/jsonschema/releases)
- [Changelog](https://github.com/Julian/jsonschema/blob/main/CHANGELOG.rst)
- [Commits](python-jsonschema/jsonschema@v4.3.1...v4.3.2)

---
updated-dependencies:
- dependency-name: jsonschema
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [junitparser](https://github.com/weiwei/junitparser) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/weiwei/junitparser/releases)
- [Changelog](https://github.com/weiwei/junitparser/blob/master/CHANGELOG.md)
- [Commits](weiwei/junitparser@2.2.0...2.3.0)

---
updated-dependencies:
- dependency-name: junitparser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions
Copy link
Contributor

Expected release notes (by @arys-splunk)

features:
remove splunk-appinspect dependency (#464) (206c7d1)

others (will not be included in Semantic-Release notes):
merge with main (c8ac474)
bump junitparser from 2.2.0 to 2.3.0 (eb35928)
bump jsonschema from 4.3.1 to 4.3.2 (6d128dd)
bump jsonschema from 4.3.0 to 4.3.1 (d3a88df)
bump junitparser from 2.2.0 to 2.3.0 (6914529)
bump jsonschema from 4.3.1 to 4.3.2 (c99298d)
remove all eventgen signs (b7c5606)
upload coverage to codecov (4dc506e)
remove release_history page (e044715)
1.12.0-beta.2 (a7c33ed)
bump jsonschema from 4.3.0 to 4.3.1 (8dc61c1)
merge from latest main (f5a1b9b)
1.12.0-beta.1 (29d176f)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ghost ghost requested review from hsekowski-splunk and uoboda-splunk December 23, 2021 11:25
@ghost ghost closed this Dec 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2021
@ghost
Copy link
Author

ghost commented Dec 28, 2021

Closing this one in favour of #499

@ghost ghost deleted the develop branch February 18, 2022 11:57
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for eventgen.conf

3 participants