feat: remove splunk-appinspect dependency (#464)

* ci: apply concurrency for build-test-release job
* refactor: use conf-parser in EventtypeParser instead of splunk-appinspect
* refactor: use conf-parser in SavedsearchesParser instead of splunk-appinspect
* refactor: use conf-parser in TransformsParser instead of splunk-appinspect
* refactor: use conf-parser in PropsParser instead of splunk-appinspect
* refactor: remove splunk-appinspect from AddonParser
* docs: remove splunk-appinspect mentions from PropsParser
* test: empty stanza in savedsearches.conf
* refactor: use new EventtypeParser in cim_field_report
* refactor: use conf-parser in eventgen.conf parser
* chore: remove create_new_eventgen
* feat: remove splunk_appinspect dependency
* chore: rename to pytest_splunk_addon_data
* chore: style the docs pagee
* ci: restructure tests
* ci: not run tests with Splunk 8.0
* refactor: move some public methods to be private
* ci: add debug-statements to pre-commit configuration

Author: Artem Rys

.github/workflows/build-test-release.yml

@@ -10,6 +10,10 @@ on:
   pull_request:
     branches: [main, develop]
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+  cancel-in-progress: true
+
 jobs:
   compliance-dependencies:
     name: Compliance Dependencies
@@ -121,7 +125,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        splunk-version: ["8.0","8.1","8.2"]
+        splunk-version: ["8.1","8.2"]
     steps:
       - uses: actions/checkout@v2
         with:
@@ -195,13 +199,22 @@ jobs:
 
   test-splunk-matrix:
     name: Test Matrix
+    needs:
+      - pre-commit
+      - compliance-dependencies
+      - compliance-copyrights
+      - test-splunk-external
+      - test-splunk-doc
+      - test-splunk-unit
+      - review_secrets
+      - review-dog-misspell
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
         python-version: [3.7]
-        splunk-version: [8.0, 8.1, 8.2]
+        splunk-version: [8.1, 8.2]
     steps:
       - uses: actions/checkout@v2
         with:
@@ -267,15 +280,7 @@ jobs:
   publish:
     name: publish
     needs:
-      - pre-commit
-      - compliance-dependencies
-      - compliance-copyrights
-      - test-splunk-external
-      - test-splunk-doc
       - test-splunk-matrix
-      - test-splunk-unit
-      - review_secrets
-      - review-dog-misspell
     runs-on: ubuntu-latest
     env:
       NEEDS: ${{ toJson(needs) }}

.pre-commit-config.yaml

@@ -18,6 +18,7 @@ repos:
     rev: v4.0.1
     hooks:
     -   id: check-merge-conflict
+    -   id: debug-statements
 -   repo: https://github.com/psf/black
     rev: 21.9b0
     hooks:

README.rst

@@ -42,13 +42,11 @@ Developing
 
 Note: Must install docker desktop, vscode or pycharm pro optional
 
-Note2: Appinspect requires libmagic verify this has been installed correctly each time a new workstation/vm is used https://dev.splunk.com/enterprise/docs/releaseapps/appinspect/splunkappinspectclitool/installappinspect
-
 .. code:: bash
 
     $ git clone --recurse-submodules -j8 [email protected]:splunk/pytest-splunk-addon.git
 
-    $ #setup python venv must be 3.7    
+    $ #setup python venv must be 3.7
     $ /Library/Frameworks/Python.framework/Versions/3.7/bin/python3 -m venv .venv
 
     $ source .venv/bin/activate
@@ -57,8 +55,6 @@ Note2: Appinspect requires libmagic verify this has been installed correctly eac
     
     $ pip3 install -r requirements.txt
 
-    $ pip3 install https://download.splunk.com/misc/appinspect/splunk-appinspect-latest.tar.gz
-
     $ python setup.py develop
     
 

docs/api_reference/sample_generation.rst

@@ -1,9 +1,9 @@
 DataGenerator
 ------------------
 
-EventgenParser
-~~~~~~~~~~~~~~~~~~
-.. automodule:: standard_lib.sample_generation.eventgen_parser
+PytestSplunkAddonDataParser
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+.. automodule:: standard_lib.sample_generation.pytest_splunk_addon_data_parser
    :members:
    :show-inheritance: