Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] make SourmashSignature printable and hashable #332

Merged
merged 3 commits into from
Sep 29, 2017

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 22, 2017

Add __str__, __repr__, and __hash__ to SourmashSignature objects.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented Sep 22, 2017

@luizirber @betatim ready for review & merge!

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #332 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage    86.9%   86.96%   +0.05%     
==========================================
  Files          13       13              
  Lines        2009     2018       +9     
  Branches       36       36              
==========================================
+ Hits         1746     1755       +9     
  Misses        262      262              
  Partials        1        1
Impacted Files Coverage Δ
sourmash_lib/signature.py 93.58% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899f26d...30d5640. Read the comment docs.

@ctb ctb changed the title [MRG] make signatures printable and hashable [MRG] make SourmashSignature printable and hashable Sep 22, 2017
@luizirber luizirber merged commit 069fb51 into master Sep 29, 2017
@luizirber luizirber deleted the feature/hashable_sigs branch September 29, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants