[MRG] fixing cross-platform cibuildwheel action for release #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2384 +/- ##
==========================================
+ Coverage 84.08% 92.19% +8.11%
==========================================
Files 130 101 -29
Lines 15070 11522 -3548
Branches 2212 2212
==========================================
- Hits 12671 10623 -2048
+ Misses 2103 603 -1500
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
AH-HAH! 9367075 induces the failure, and this eventually led me to THIS: https://users.rust-lang.org/t/cargo-uses-too-much-memory-being-run-in-qemu/76531 which seems to be the same problem we're facing!!! Now to see if their solution works... |
|
aaaaand this issue too - rust-lang/cargo#10583 |
|
it worked! firing for effect... |
ctb
changed the title
|
Merging into latest to check that it works there, too. |
This was referenced Dec 2, 2022
ctb
added a commit
that referenced
this pull request
Dec 2, 2022
This PR continues the cibuildwheel exploration that started with a fix for building the wheels (#2384 and #2385). The saga continues like so: When building the release candidates, we don't get "clean" rcN wheels. I think this is because when I run `cargo update` in the cibuildwheel action it's actually updating the Rust packages and we're getting a version bump from that. Yay? (See screenshot of releases page with 'dev' yada in wheel names.) <img width="1025" alt="Screen Shot 2022-12-02 at 7 15 52 AM" src="https://user-images.githubusercontent.com/51016/205325234-9ec0c6c2-7cbc-42c7-9727-fd700ef59320.png"> This PR changes `cargo update` to `cargo update --dry-run` which should update the crates.io index without actually changing `Cargo.lock` and pushing a version bump. We Shall See!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QEMU/cibuildwheel based wheel-builds were exiting on
cargo update:which seems to have been caused by an out-of-memory error; see https://users.rust-lang.org/t/cargo-uses-too-much-memory-being-run-in-qemu/76531 for what looks like the same problem.
This PR fixes the problem using the same fix as in https://users.rust-lang.org/t/cargo-uses-too-much-memory-being-run-in-qemu/76531.