[MRG] fix manifest load function to properly catch gzip.BadGzipFile
#2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2375 +/- ##
==========================================
+ Coverage 84.07% 92.19% +8.12%
==========================================
Files 130 101 -29
Lines 15061 11516 -3545
Branches 2212 2212
==========================================
- Hits 12662 10617 -2045
+ Misses 2103 603 -1500
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Ready for review & merge @sourmash-bio/devs |
|
Updated with latest PRs - ready for review ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in
sourmash_argsfor manifest loading wasn't properly catching thegzip.BadGzipFileexception.Fixes #2370