Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine latest dependabot PRs: cibuildwheel, finch, serde_json #2343

Merged
merged 8 commits into from
Oct 22, 2022
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Oct 22, 2022

Try combining #2335, #2324, and #2283.

dependabot bot and others added 8 commits September 14, 2022 12:14
Bumps [finch](https://github.com/onecodex/finch-rs) from 0.4.1 to 0.4.3.
- [Release notes](https://github.com/onecodex/finch-rs/releases)
- [Commits](onecodex/finch-rs@v0.4.1...v0.4.3)

---
updated-dependencies:
- dependency-name: finch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.85 to 1.0.86.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.85...v1.0.86)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.10.2 to 2.11.1.
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](pypa/cibuildwheel@v2.10.2...v2.11.1)

---
updated-dependencies:
- dependency-name: pypa/cibuildwheel
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [counter](https://github.com/coriolinus/counter-rs) from 0.5.6 to 0.5.7.
- [Release notes](https://github.com/coriolinus/counter-rs/releases)
- [Commits](coriolinus/counter-rs@v0.5.6...v0.5.7)

---
updated-dependencies:
- dependency-name: counter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #2343 (5c1a716) into latest (a8bd648) will decrease coverage by 0.82%.
The diff coverage is 77.57%.

@@            Coverage Diff             @@
##           latest    #2343      +/-   ##
==========================================
- Coverage   84.82%   84.00%   -0.83%     
==========================================
  Files         131      129       -2     
  Lines       15676    14966     -710     
  Branches     2251     2192      -59     
==========================================
- Hits        13297    12572     -725     
- Misses       2085     2100      +15     
  Partials      294      294              
Flag Coverage Δ
python 92.14% <100.00%> (-0.01%) ⬇️
rust 57.78% <14.28%> (-7.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/errors.rs 0.00% <0.00%> (ø)
src/core/src/ffi/signature.rs 0.00% <0.00%> (ø)
src/core/src/index/linear.rs 17.64% <0.00%> (ø)
src/core/tests/minhash.rs 100.00% <ø> (+0.22%) ⬆️
src/sourmash/cli/compare.py 100.00% <ø> (ø)
src/core/src/sketch/minhash.rs 86.75% <14.28%> (-1.32%) ⬇️
src/core/src/index/revindex.rs 28.70% <25.00%> (-5.21%) ⬇️
src/core/src/index/sbt/mod.rs 66.76% <100.00%> (ø)
src/sourmash/cli/categorize.py 100.00% <100.00%> (ø)
src/sourmash/cli/gather.py 100.00% <100.00%> (ø)
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb ctb merged commit 101845a into latest Oct 22, 2022
@ctb ctb deleted the merge_rust branch October 22, 2022 14:27
@luizirber
Copy link
Member

We have a testing gap for MSRV for optional features, I think finch bumped the MSRV. Not a dealbreaker, just FYI

@ctb
Copy link
Contributor Author

ctb commented Oct 22, 2022

YOU PROMISED ME!

@luizirber
Copy link
Member

YOU PROMISED ME!

Just saying we have another opportunity for improvement =]

(and optional features are optional, and I would argue outside stability guarantees... If you reach for them, you're probably also using a fairly new Rust version, and not depending on some ancient version in Ubuntu)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants