Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update kreport proportion for better resolution; match other tool outputs #2331

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

bluegenes
Copy link
Contributor

Fixes #2330

multiply kreport proportion * 100:

  • becomes percent with 2 decimal points of resolution (e.g. 0.91 --> 91.08)
  • matches output from other tools

@bluegenes bluegenes changed the title update proportion for better resolution; match other tool outputs [MRG] update proportion for better resolution; match other tool outputs Oct 14, 2022
@bluegenes
Copy link
Contributor Author

bluegenes commented Oct 14, 2022

@ctb @sourmash-bio/devs should be ready for review

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #2331 (1d7fb04) into latest (5d15e86) will increase coverage by 8.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2331      +/-   ##
==========================================
+ Coverage   84.09%   92.14%   +8.05%     
==========================================
  Files         129      100      -29     
  Lines       14950    11421    -3529     
  Branches     2191     2191              
==========================================
- Hits        12572    10524    -2048     
+ Misses       2083      602    -1481     
  Partials      295      295              
Flag Coverage Δ
python 92.14% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/tax/tax_utils.py 98.32% <100.00%> (+<0.01%) ⬆️
src/core/src/ffi/hyperloglog.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/ffi/utils.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/ffi/mod.rs
src/core/src/ffi/index/mod.rs
src/core/tests/minhash.rs
src/core/src/cmd.rs
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bluegenes bluegenes merged commit 5abc988 into latest Oct 15, 2022
@bluegenes bluegenes deleted the kreport-proportion branch October 15, 2022 21:04
bluegenes added a commit that referenced this pull request Nov 15, 2022
- minor wording
- upd kreport format with change from #2331
@ctb ctb changed the title [MRG] update proportion for better resolution; match other tool outputs [MRG] update kreport proportion for better resolution; match other tool outputs Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kreport percentage should be *100
2 participants