[MRG] return Err for angular_similarity when abundance tracking is off

[ctb]

Replaces unimplemented!() in KmerMinHash and KmerMinHashBTree angular_similarity functions with appropriate error handling.

Fixes #898.

[codecov]

Codecov Report

Merging #2327 (9b1885a) into latest (49008f1) will decrease coverage by 26.05%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           latest    #2327       +/-   ##
===========================================
- Coverage   84.09%   58.04%   -26.06%     
===========================================
  Files         129       29      -100     
  Lines       14947     3530    -11417     
  Branches     2191        0     -2191     
===========================================
- Hits        12570     2049    -10521     
+ Misses       2082     1481      -601     
+ Partials      295        0      -295     

Flag	Coverage Δ
python	?
rust	58.04% <66.66%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/core/src/errors.rs	0.00% <0.00%> (ø)
src/core/tests/minhash.rs	100.00% <ø> (ø)
src/core/src/sketch/minhash.rs	88.01% <100.00%> (+0.02%)	⬆️
src/sourmash/np_utils.py
src/sourmash/cli/storage/convert.py
src/sourmash/cli/migrate.py
src/sourmash/cli/info.py
src/sourmash/cli/lca/summarize.py
src/sourmash/cli/tax/metagenome.py
src/sourmash/cli/plot.py
... and 93 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ctb]

Ready for review @luizirber @mr-eyes

[mr-eyes]

Looks very good to me.

[ctb]

cool, thanks! will wait for @luizirber to have a chance to comment too, since it's early days for me & 🦀

[luizirber]

Nice!

[ctb]

@luizirber looks like I need to re-run cbindgen, yes? The installation instructions say I should add it to my Cargo.toml but it's not in sourmash's Cargo.toml...?

[ctb]

(I see the Makefile rule for include/sourmash.h, just curious about how I should install cbindgen if it's a non-standard way?)

[ctb]

oh. The actual docs just say to use cargo install cbindgen, and that worked just fine!

Updated include/sourmash.h in 9b1885a. Will merge once tests pass.