[MRG] Fix multigather so that the output CSV contains all matches.
#2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2322 +/- ##
==========================================
+ Coverage 84.84% 92.14% +7.30%
==========================================
Files 131 100 -31
Lines 15689 11420 -4269
Branches 2190 2191 +1
==========================================
- Hits 13311 10523 -2788
+ Misses 2083 602 -1481
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctb
changed the title
multigather so that the output CSV contains all matches.multigather so that the output CSV contains all matches.
ctb
changed the title
multigather so that the output CSV contains all matches.multigather so that the output CSV contains all matches.
…o fix/multigather_indent
|
@sourmash-bio/devs @dkoslicki ready for review! |
dkoslicki
approved these changes
Oct 14, 2022
This was referenced Aug 19, 2023
olgabot
pushed a commit
that referenced
this pull request
Aug 21, 2023
Note: PR into #2065. This PR updates #2065 with all the changes from `latest`. This includes the fix & update to multigather in #2322, which: - fixes the output of multigather to include more than one line 😆 - prints out the output filename - supports `--output-dir` No functional changes are made beyond the merge, so some tests are still failing; will discuss fixes in yet a new PR :). --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Keya Barve <[email protected]> Co-authored-by: ccbaumler <[email protected]> Co-authored-by: Tessa Pierce Ward <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylor Reiter <[email protected]> Co-authored-by: Erik Young <[email protected]> Co-authored-by: David Koslicki <[email protected]> Co-authored-by: Luiz Irber <[email protected]> Co-authored-by: Colton Baumler <[email protected]> Co-authored-by: Luiz Irber <[email protected]> Co-authored-by: N. Tessa Pierce-Ward <[email protected]> Co-authored-by: Peter Cock <[email protected]> Co-authored-by: Francesco Beghini <[email protected]> Co-authored-by: Jason Stajich <[email protected]> Co-authored-by: Katrin Leinweber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2321 so that more than one output line is placed in the CSV. Oops!
It also adds a notification of what the CSV output file name is.
Last but not least, it supports
--output-diras a way to set the base path for all output files.Fixes #2321.
TODO:
multigatherCSV output uses signaturefilenameas basename. #2328