Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update JOSS for sourmash 4.4 #2006

Merged
merged 4 commits into from
Jan 23, 2023
Merged

[MRG] update JOSS for sourmash 4.4 #2006

merged 4 commits into from
Jan 23, 2023

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Apr 27, 2022

draft for sourmash 4.x.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2006 (4d11262) into update/joss (e27adc0) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           update/joss    #2006   +/-   ##
============================================
  Coverage        92.22%   92.22%           
============================================
  Files              101      101           
  Lines            11496    11496           
  Branches          2403     2403           
============================================
  Hits             10602    10602           
  Misses             598      598           
  Partials           296      296           
Flag Coverage Δ
python 92.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bluegenes bluegenes changed the title [WIP] update JOSS for sourmash 4.4 [MRG] update JOSS for sourmash 4.4 Dec 19, 2022
@bluegenes
Copy link
Contributor Author

@ctb ready for review

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two suggestions => good to go!

paper.md Outdated Show resolved Hide resolved
paper.md Outdated Show resolved Hide resolved
@bluegenes
Copy link
Contributor Author

bluegenes commented Jan 23, 2023

merging this so I can work in the base JOSS update branch

@bluegenes bluegenes merged commit 0350d13 into update/joss Jan 23, 2023
@bluegenes bluegenes deleted the joss-ani branch January 23, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants