Add tests to filter types and fix options#7007
Merged
franmomu merged 1 commit intosonata-project:3.xfrom Apr 9, 2021
Merged
Conversation
VincentLanglet
approved these changes
Apr 2, 2021
phansys
approved these changes
Apr 2, 2021
Member
phansys
left a comment
There was a problem hiding this comment.
I'll try to check these changes in a real project, but at first sight, they seem right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
I wanted to work a bit with filters, but before starting, better to have some tests.
Adding them showed that:
formatis not valid forDateTimeRangeTypebecause this Type adds twoDateTimeTypethat have that configuration (notDateTimeRangeTypeitself), so I've added theformatoption in thefield_optionsoption so is passed to thoseDateTimeTypeand changed fromDateType::HTML5_FORMATtoDateTimeType::HTML5_FORMAT.date_formatis not valid forDateType, so I've changed it toformat.Another interesting part I was thinking was... why has it worked so far? Because having:
The
field_optionsoption is an array and we always override this array (here for example), and by doing this, it does not merge the values, so thisdate_formatalways gets lost.If we want to allow nested options we should use a closure instead (useful also for #6078), but that's another issue (that I think we should consider).
I am targeting this branch, because these changes are BC.
Changelog