Add tests to filter types and fix options

src/Form/Type/Filter/DateRangeType.php

@@ -84,7 +84,11 @@ public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefaults([
             'field_type' => FormDateRangeType::class,
-            'field_options' => ['format' => DateType::HTML5_FORMAT],
+            'field_options' => [
+                'field_options' => [
+                    'format' => DateType::HTML5_FORMAT,
+                ],
+            ],
         ]);
     }
 }

src/Form/Type/Filter/DateTimeRangeType.php

@@ -16,7 +16,7 @@
 use Sonata\AdminBundle\Form\Type\Operator\DateRangeOperatorType;
 use Sonata\Form\Type\DateTimeRangeType as FormDateTimeRangeType;
 use Symfony\Component\Form\AbstractType;
-use Symfony\Component\Form\Extension\Core\Type\DateType;
+use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Translation\TranslatorInterface;
@@ -84,7 +84,9 @@ public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefaults([
             'field_type' => FormDateTimeRangeType::class,
-            'field_options' => ['date_format' => DateType::HTML5_FORMAT],
+            'field_options' => [
+                'field_options' => ['date_format' => DateTimeType::HTML5_FORMAT],
+            ],
         ]);
     }
 }

src/Form/Type/Filter/DateType.php

@@ -108,7 +108,7 @@ public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefaults([
             'field_type' => FormDateType::class,
-            'field_options' => ['date_format' => FormDateType::HTML5_FORMAT],
+            'field_options' => ['format' => FormDateType::HTML5_FORMAT],
         ]);
     }
 }

tests/Form/Type/Filter/BaseTypeTest.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\AdminBundle\Tests\Form\Type\Filter;
+
+use Symfony\Component\Form\Test\TypeTestCase;
+
+abstract class BaseTypeTest extends TypeTestCase
+{
+    public function testHasTypeAndValue(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $this->assertTrue($form->has('type'));
+        $this->assertTrue($form->has('value'));
+    }
+
+    public function testHasFieldTypeAndOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $this->assertTrue($form->getConfig()->hasOption('field_type'));
+        $this->assertTrue($form->getConfig()->hasOption('field_options'));
+    }
+
+    /**
+     * @phpstan-return class-string
+     */
+    abstract protected function getTestedType(): string;
+}

tests/Form/Type/Filter/ChoiceTypeTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\AdminBundle\Tests\Form\Type\Filter;
+
+use Sonata\AdminBundle\Form\Type\Filter\ChoiceType;
+use Symfony\Component\Translation\TranslatorInterface;
+
+final class ChoiceTypeTest extends BaseTypeTest
+{
+    public function testDefaultOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $view = $form->createView();
+
+        $this->assertFalse($view->children['type']->vars['required']);
+        $this->assertFalse($view->children['value']->vars['required']);
+    }
+
+    protected function getTestedType(): string
+    {
+        return ChoiceType::class;
+    }
+
+    /**
+     * NEXT_MAJOR: Remove this method.
+     *
+     * @return ChoiceType[]
+     */
+    protected function getTypes(): array
+    {
+        return [
+            new ChoiceType($this->createStub(TranslatorInterface::class)),
+        ];
+    }
+}

tests/Form/Type/Filter/DateRangeTypeTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\AdminBundle\Tests\Form\Type\Filter;
+
+use Sonata\AdminBundle\Form\Type\Filter\DateRangeType;
+use Symfony\Component\Translation\TranslatorInterface;
+
+final class DateRangeTypeTest extends BaseTypeTest
+{
+    public function testDefaultOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $view = $form->createView();
+
+        $this->assertFalse($view->children['type']->vars['required']);
+        $this->assertTrue($view->children['value']->vars['required']);
+    }
+
+    protected function getTestedType(): string
+    {
+        return DateRangeType::class;
+    }
+
+    /**
+     * NEXT_MAJOR: Remove this method.
+     *
+     * @return DateRangeType[]
+     */
+    protected function getTypes(): array
+    {
+        return [
+            new DateRangeType($this->createStub(TranslatorInterface::class)),
+        ];
+    }
+}

tests/Form/Type/Filter/DateTimeRangeTypeTest.php

@@ -15,13 +15,22 @@
 
 use Sonata\AdminBundle\Form\Type\Filter\DateTimeRangeType;
 use Sonata\Form\Type\DateTimeRangeType as FormDateTimeRangeType;
-use Symfony\Component\Form\Extension\Core\Type\DateType;
-use Symfony\Component\Form\Test\TypeTestCase;
+use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Translation\TranslatorInterface;
 
-final class DateTimeRangeTypeTest extends TypeTestCase
+final class DateTimeRangeTypeTest extends BaseTypeTest
 {
+    public function testDefaultOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $view = $form->createView();
+
+        $this->assertFalse($view->children['type']->vars['required']);
+        $this->assertTrue($view->children['value']->vars['required']);
+    }
+
     public function testGetDefaultOptions(): void
     {
         $translator = $this->createStub(TranslatorInterface::class);
@@ -36,8 +45,25 @@ public function testGetDefaultOptions(): void
 
         $expected = [
             'field_type' => FormDateTimeRangeType::class,
-            'field_options' => ['date_format' => DateType::HTML5_FORMAT],
+            'field_options' => ['field_options' => ['date_format' => DateTimeType::HTML5_FORMAT]],
         ];
         $this->assertSame($expected, $options);
     }
+
+    protected function getTestedType(): string
+    {
+        return DateTimeRangeType::class;
+    }
+
+    /**
+     * NEXT_MAJOR: Remove this method.
+     *
+     * @return DateTimeRangeType[]
+     */
+    protected function getTypes(): array
+    {
+        return [
+            new DateTimeRangeType($this->createStub(TranslatorInterface::class)),
+        ];
+    }
 }

tests/Form/Type/Filter/DateTimeTypeTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\AdminBundle\Tests\Form\Type\Filter;
+
+use Sonata\AdminBundle\Form\Type\Filter\DateTimeType;
+use Symfony\Component\Translation\TranslatorInterface;
+
+final class DateTimeTypeTest extends BaseTypeTest
+{
+    public function testDefaultOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $view = $form->createView();
+
+        $this->assertFalse($view->children['type']->vars['required']);
+        $this->assertFalse($view->children['value']->vars['required']);
+    }
+
+    protected function getTestedType(): string
+    {
+        return DateTimeType::class;
+    }
+
+    /**
+     * NEXT_MAJOR: Remove this method.
+     *
+     * @return DateTimeType[]
+     */
+    protected function getTypes(): array
+    {
+        return [
+            new DateTimeType($this->createStub(TranslatorInterface::class)),
+        ];
+    }
+}

tests/Form/Type/Filter/DateTypeTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\AdminBundle\Tests\Form\Type\Filter;
+
+use Sonata\AdminBundle\Form\Type\Filter\DateType;
+use Symfony\Component\Translation\TranslatorInterface;
+
+final class DateTypeTest extends BaseTypeTest
+{
+    public function testDefaultOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $view = $form->createView();
+
+        $this->assertFalse($view->children['type']->vars['required']);
+        $this->assertFalse($view->children['value']->vars['required']);
+    }
+
+    protected function getTestedType(): string
+    {
+        return DateType::class;
+    }
+
+    /**
+     * NEXT_MAJOR: Remove this method.
+     *
+     * @return DateType[]
+     */
+    protected function getTypes(): array
+    {
+        return [
+            new DateType($this->createStub(TranslatorInterface::class)),
+        ];
+    }
+}

tests/Form/Type/Filter/DefaultTypeTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Sonata Project package.
+ *
+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Sonata\AdminBundle\Tests\Form\Type\Filter;
+
+use Sonata\AdminBundle\Form\Type\Filter\DefaultType;
+
+final class DefaultTypeTest extends BaseTypeTest
+{
+    public function testDefaultOptions(): void
+    {
+        $form = $this->factory->create($this->getTestedType());
+
+        $view = $form->createView();
+
+        $this->assertFalse($view->children['type']->vars['required']);
+        $this->assertFalse($view->children['value']->vars['required']);
+    }
+
+    protected function getTestedType(): string
+    {
+        return DefaultType::class;
+    }
+}