[PoC] Use options resolver in BaseFieldDescription#6078
[PoC] Use options resolver in BaseFieldDescription#6078phansys wants to merge 2 commits intosonata-project:masterfrom
BaseFieldDescription#6078Conversation
|
Could you please rebase your PR and fix merge conflicts? |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@phansys I think this could be great, just in case you want to|can continue working. |
|
I agree @franmomu, I need to find enough time for this task. |
|
I'll leave it open, so it doesn't get lost. |
|
There was some discussions about this:
Some options are global: So I'm not sure we can use an option resolver, since we should allow every possible options. |
Subject
I am targeting this branch, because this change breaks BC.
Changelog
To do
BaseFieldDescription::mergeOptions().Since
BaseFieldDescription::mergeOptions()calls toarray_merge_recursive(), the previously set options are being overridden as array:This, by instance, is causing "virtual_field" option to hold an array instead of a boolean at
ListMapper::add().