Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2017 reconcile fails to replace nested array with object #2020

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

takeramagan
Copy link
Contributor

  1. fix reconcile fails to replace nested array with object #2017 reconcile fails to replace nested array with object
  2. add tests

Copy link

changeset-bot bot commented Jan 7, 2024

⚠️ No Changeset found

Latest commit: 01e6a3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid ryansolid merged commit 8c1b266 into solidjs:main Jan 8, 2024
1 check passed
@ryansolid
Copy link
Member

Thanks. I went with a smaller fix that I hope works as well (passes the tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconcile fails to replace nested array with object
2 participants