reconcile fails to replace nested array with object

[Bubz43]

Describe the bug

Basically the reverse of this issue. Using reconcile to replace a nested value that is an array with an object still leaves it as an array.

Your Example Website or App

https://playground.solidjs.com/anonymous/d43decad-3911-4beb-99e0-6a166b6655c6

Steps to Reproduce the Bug or Issue

  const [store, setStore] = createStore<{ value: [] | {} }>({ value: [] });
  setStore(reconcile({ value: {} }));
  expect(Array.isArray(store.value)).toBe(false);

Expected behavior

Expect the array to be replaced with an object, works without reconcile.

Screenshots or Videos

No response

Platform

• OS: Linux
• Browser: Vivaldi
• Version: 6.5

Additional context

I don't think the playground version of solid has been updated to use the latest version so obj -> array bug exists there, but this bug exists both on older and latest (1.8.8) version.

[takeramagan]

I have an example here:

const state = {
  value: []
}
Object.assign(state.value, { a: 'b'})
console.log(Array.isArray(state.value)); // true

const state2 = {
  value: {}
}

Object.assign(state.value, [2,3])
console.log(Array.isArray(state2.value)); // false

We are doing something similar in reconcile, so this bug happens

[ryansolid]

Hmm.. ok. I need to think about this one a moment because this one is innately trickier. I think you are right that reconcile should update. What comes to mind is that like:

setStore("value", {0: something });

Shouldn't turn it into an object if value was an array. But this will:

setStore({value: {0: something }});

But yeah reconcile doesn't care about any of that. It should just swap.