Skip to content

vote-program: expose handler mod under dcou#8312

Closed
buffalojoec wants to merge 1 commit intoanza-xyz:masterfrom
buffalojoec:vote-handler-dcou
Closed

vote-program: expose handler mod under dcou#8312
buffalojoec wants to merge 1 commit intoanza-xyz:masterfrom
buffalojoec:vote-handler-dcou

Conversation

@buffalojoec
Copy link
Copy Markdown

Problem

The handler module - which contains a unifying API consisting of VoteStateHandle and VoteStateHandler - is intentionally private. However, it will be extremely useful to be able to use this unifying API both around the monorepo and in the Stake program tests.

Summary of Changes

Make the handler module public behind DCOU.

@buffalojoec buffalojoec requested a review from jstarry October 2, 2025 06:43
@mergify
Copy link
Copy Markdown

mergify Bot commented Oct 2, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@buffalojoec buffalojoec force-pushed the vote-handler-dcou branch 2 times, most recently from fc32d3c to 6cd1c0b Compare October 2, 2025 06:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (75ee010) to head (1d867ec).
⚠️ Report is 2038 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8312    +/-   ##
========================================
  Coverage    83.2%    83.2%            
========================================
  Files         836      836            
  Lines      367032   367032            
========================================
+ Hits       305410   305536   +126     
+ Misses      61622    61496   -126     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but there is a way to conditionally add the visibility via cfg FYI

@buffalojoec
Copy link
Copy Markdown
Author

This is fine but there is a way to conditionally add the visibility via cfg FYI

Yes, with qualifier, but it actually throws a downstream rustc error about inline module declarations being unstable (?)

@jstarry
Copy link
Copy Markdown

jstarry commented Oct 2, 2025

ah ok, well in any case I already approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants