This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Cleanup #22182#22205
Merged
Lichtso merged 4 commits intosolana-labs:masterfrom Dec 31, 2021
Merged
Conversation
…rocess_instruction_compute_budget() into test_process_instruction().
Codecov Report
@@ Coverage Diff @@
## master #22205 +/- ##
=========================================
- Coverage 81.1% 81.0% -0.1%
=========================================
Files 523 523
Lines 146609 146487 -122
=========================================
- Hits 118904 118748 -156
- Misses 27705 27739 +34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#22182 was made right in between my program-runtime refactorings (see #22165 and https://github.com/Lichtso/solana/tree/refactor/remove_keyed_account_from_program_runtime), and is based on an incomplete state of the program-runtime in transition. Together with the earlier #22059, its revert #22174 and its fix #22202 lead to heavy merge conflicts three times now. Thus, I split the adoption of my refactoring to that up, into this PR.
Summary of Changes
compute_units_consumedofProcessInstructionResultinto a&mutparameter.test_process_cross_program(),test_native_invoke()andtest_process_instruction_compute_budget()intotest_process_instruction().Fixes #