This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: InstructionAccount indices#22165
Merged
Lichtso merged 1 commit intosolana-labs:masterfrom Dec 30, 2021
Merged
Conversation
838ce8e to
8fc2bdf
Compare
8fc2bdf to
e62d249
Compare
e62d249 to
2a306d3
Compare
2a306d3 to
590c815
Compare
590c815 to
aef014d
Compare
Codecov Report
@@ Coverage Diff @@
## master #22165 +/- ##
=========================================
- Coverage 81.1% 81.0% -0.1%
=========================================
Files 523 523
Lines 146370 146459 +89
=========================================
+ Hits 118747 118762 +15
- Misses 27623 27697 +74 |
This was referenced Dec 31, 2021
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The property
indexofInstructionAccountshould be calledindex_in_transaction.Also, we currently search for the
index_in_callerin the program runtime multiple times and could be reusing them.Thus it makes sense to introduce an
index_in_callerproperty as well.Summary of Changes
indexofInstructionAccountintoindex_in_transactionandindex_in_caller.transaction_context.rsFixes #