This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Revert "Count compute units even when transaction errors (#22059)"#22174
Merged
carllin merged 1 commit intosolana-labs:masterfrom Dec 30, 2021
Merged
Revert "Count compute units even when transaction errors (#22059)"#22174carllin merged 1 commit intosolana-labs:masterfrom
carllin merged 1 commit intosolana-labs:masterfrom
Conversation
Contributor
|
@carllin did this break anything? or did it just not do what you intended? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fix doesn't fix update cost model on replay side, and is complex
Summary of Changes
Revert
Fixes #