Remove unnecessary transfer hook token program account info

[Arrowana]

There is no need for the token program in account info

https://github.com/solana-program/transfer-hook/tree/main/interface

It is not required or necessary

[yugure-orca]

@Arrowana
Thanks for the PR!

[yugure-orca]

Knowledge update:

• in CPI context, the account info of the invoked program is optional (not required)
  • Updates documentation around CPI and InvokeContext::get_keyed_accounts solana-labs/solana#21633
  • Add test to enforce that program id account info for CPI is optional solana-labs/solana#22069

note: I tested whether a self-CPI could work without including the program's AccountInfo—just in case it was no longer required—but it didn’t work. In other words, while we can omit it in the CPI context, we still need to receive the program being called as an account, not just as a program_id.

[Arrowana]

Knowledge update:

• in CPI context, the account info of the invoked program is optional (not required)

  • Updates documentation around CPI and InvokeContext::get_keyed_accounts solana-labs/solana#21633
  • Add test to enforce that program id account info for CPI is optional solana-labs/solana#22069

note: I tested whether a self-CPI could work without including the program's AccountInfo—just in case it was no longer required—but it didn’t work. In other words, while we can omit it in the CPI context, we still need to receive the program being called as an account, not just as a program_id.

Correct, it is also planned to completely remove the need to pass a program to be able to cpi into it. https://github.com/solana-foundation/solana-improvement-documents/blob/main/proposals/0163-lift-cpi-caller-restriction.md
This would simplify tx building even further.

[yugure-orca]

Correct, it is also planned to completely remove the need to pass a program to be able to cpi into it. https://github.com/solana-foundation/solana-improvement-documents/blob/main/proposals/0163-lift-cpi-caller-restriction.md This would simplify tx building even further.

Cool, good to know.
Thanks again!

Once self-CPI becomes possible, we should be able to emit events without the risk of them being truncated — although there’s still the issue of the event authority....

The PR looks good to me, so planning to merge the PR before the next upgrade.

[yugure-orca]

Notes for SIMD-0163 Lift CPI caller restriction:

• It has been withdrawn due to security concerns.
• For now, the prospect of being able to freely call programs in the future is off the table.
• However, this PR is still valid. The caller (the Whirlpool program) always receives the Token-2022 (if token is a Token-2022 based token), which guarantees that the caller holds the callee’s AccountInfo.