This repository was archived by the owner on Jan 22, 2025. It is now read-only.
tracks erasure coding shreds indices explicitly#21822
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Dec 19, 2021
Merged
tracks erasure coding shreds indices explicitly#21822behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21822 +/- ##
=========================================
+ Coverage 81.2% 81.3% +0.1%
=========================================
Files 516 516
Lines 144284 144936 +652
=========================================
+ Hits 117256 117941 +685
+ Misses 27028 26995 -33 |
behzadnouri
force-pushed
the
next-code-index
branch
5 times, most recently
from
9a6ab95 to
db1e9dc
Compare
The indices for erasure coding shreds are tied to data shreds: https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921 However with the upcoming changes to erasure schema, there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds. The commit adds constructs to track coding shreds indices explicitly.
behzadnouri
force-pushed
the
next-code-index
branch
from
db1e9dc to
0eb9a11
Compare
jbiseda
approved these changes
Dec 17, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Dec 23, 2021
The indices for erasure coding shreds are tied to data shreds: https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921 However with the upcoming changes to erasure schema, there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds. The commit adds constructs to track coding shreds indices explicitly. (cherry picked from commit 65d59f4)
mergify Bot
added a commit
that referenced
this pull request
Dec 23, 2021
The indices for erasure coding shreds are tied to data shreds: https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921 However with the upcoming changes to erasure schema, there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds. The commit adds constructs to track coding shreds indices explicitly. (cherry picked from commit 65d59f4) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
mergify Bot
pushed a commit
that referenced
this pull request
Feb 5, 2022
The indices for erasure coding shreds are tied to data shreds: https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921 However with the upcoming changes to erasure schema, there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds. The commit adds constructs to track coding shreds indices explicitly. (cherry picked from commit 65d59f4) # Conflicts: # core/benches/retransmit_stage.rs # core/benches/shredder.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/broadcast_fake_shreds_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/window_service.rs # ledger/src/blockstore.rs # ledger/src/shred.rs # ledger/tests/shred.rs
mergify Bot
added a commit
that referenced
this pull request
Feb 6, 2022
…2969) * tracks erasure coding shreds' indices explicitly (#21822) The indices for erasure coding shreds are tied to data shreds: https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921 However with the upcoming changes to erasure schema, there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds. The commit adds constructs to track coding shreds indices explicitly. (cherry picked from commit 65d59f4) # Conflicts: # core/benches/retransmit_stage.rs # core/benches/shredder.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/broadcast_fake_shreds_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/window_service.rs # ledger/src/blockstore.rs # ledger/src/shred.rs # ledger/tests/shred.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The indices for erasure coding shreds are tied to data shreds:
https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921
However with upcoming changes to erasure schema there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds.
Summary of Changes