Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

tracks erasure coding shreds indices explicitly (backport #21822)#22094

Merged
mergify[bot] merged 1 commit intov1.9from
mergify/bp/v1.9/pr-21822
Dec 23, 2021
Merged

tracks erasure coding shreds indices explicitly (backport #21822)#22094
mergify[bot] merged 1 commit intov1.9from
mergify/bp/v1.9/pr-21822

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Dec 23, 2021

This is an automatic backport of pull request #21822 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The indices for erasure coding shreds are tied to data shreds:
https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921

However with the upcoming changes to erasure schema, there will be more
erasure coding shreds than data shreds and we can no longer infer coding
shreds indices from data shreds.

The commit adds constructs to track coding shreds indices explicitly.

(cherry picked from commit 65d59f4)
@mergify mergify Bot added the automerge Merge this Pull Request automatically once CI passes label Dec 23, 2021
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Dec 23, 2021

automerge label removed due to a CI failure

@mergify mergify Bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Dec 23, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2021

Codecov Report

Merging #22094 (9c60f16) into v1.9 (8708186) will decrease coverage by 0.0%.
The diff coverage is 75.0%.

@@            Coverage Diff            @@
##             v1.9   #22094     +/-   ##
=========================================
- Coverage    81.2%    81.2%   -0.1%     
=========================================
  Files         516      516             
  Lines      144340   144404     +64     
=========================================
+ Hits       117234   117270     +36     
- Misses      27106    27134     +28     

@mergify mergify Bot merged commit be0bcd8 into v1.9 Dec 23, 2021
@mergify mergify Bot deleted the mergify/bp/v1.9/pr-21822 branch December 23, 2021 19:40
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2022

This PR has been automatically locked since there has not been any activity in past 14 days after it was merged.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes locked PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant