This repository was archived by the owner on Jan 22, 2025. It is now read-only.
tracks erasure coding shreds indices explicitly (backport #21822)#22969
Merged
mergify[bot] merged 2 commits intov1.8from Feb 6, 2022
Merged
tracks erasure coding shreds indices explicitly (backport #21822)#22969mergify[bot] merged 2 commits intov1.8from
mergify[bot] merged 2 commits intov1.8from
Conversation
The indices for erasure coding shreds are tied to data shreds: https://github.com/solana-labs/solana/blob/90f41fd9b/ledger/src/shred.rs#L921 However with the upcoming changes to erasure schema, there will be more erasure coding shreds than data shreds and we can no longer infer coding shreds indices from data shreds. The commit adds constructs to track coding shreds indices explicitly. (cherry picked from commit 65d59f4) # Conflicts: # core/benches/retransmit_stage.rs # core/benches/shredder.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/broadcast_fake_shreds_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/window_service.rs # ledger/src/blockstore.rs # ledger/src/shred.rs # ledger/tests/shred.rs
9dd6615 to
8af11eb
Compare
8af11eb to
48e3405
Compare
Contributor
|
😱 New commits were pushed while the automerge label was present. |
Contributor
Author
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## v1.8 #22969 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 464 464
Lines 131942 132000 +58
=======================================
+ Hits 107770 107840 +70
+ Misses 24172 24160 -12 |
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #21822 done by Mergify.
Cherry-pick of 65d59f4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com