This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Feature-gate stake program#13394
Merged
mergify[bot] merged 5 commits intosolana-labs:masterfrom Nov 6, 2020
Merged
Conversation
mvines
reviewed
Nov 4, 2020
mvines
reviewed
Nov 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #13394 +/- ##
=========================================
+ Coverage 81.9% 82.1% +0.1%
=========================================
Files 376 378 +2
Lines 88405 89963 +1558
=========================================
+ Hits 72424 73866 +1442
- Misses 15981 16097 +116 |
Contributor
|
Any thoughts one replacing all of the math in the stake program with checked variants while we're replacing the program? It might save us some trouble in the future |
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
from
39a0613 to
875cb80
Compare
Contributor
Author
|
@mvines how does this look now? |
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
2 times, most recently
from
4e5fbc1 to
f45f989
Compare
Contributor
I think that looks good now. My preference would be to break out the new bank mechanism from the rest of this PR. That I think can be reviewed and landed first (@ryoqun probably should look at it as well). Then the application of it to the stake account is a second PR |
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
2 times, most recently
from
40bcd27 to
c802487
Compare
This was referenced Nov 4, 2020
Merged
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
2 times, most recently
from
f2df58b to
ecace66
Compare
ryoqun
reviewed
Nov 5, 2020
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
3 times, most recently
from
d875acb to
8c34ce8
Compare
Contributor
Author
|
@mvines this is ready for proper review. Thank you! |
mvines
reviewed
Nov 6, 2020
Contributor
mvines
left a comment
mvines
left a comment
There was a problem hiding this comment.
How should I review legacy_stake.stake.rs?
Contributor
Specifically without a diff commit from the original stake_stake.rs, it's really hard to see what, if anything has changed |
Contributor
|
(oops) |
Contributor
Author
Fair! Let me make you a diff commit |
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
from
8c34ce8 to
3ce5eba
Compare
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
2 times, most recently
from
580291b to
095098a
Compare
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
from
095098a to
4e441c0
Compare
CriesofCarrots
force-pushed
the
feature-gate-stake-program
branch
from
4e441c0 to
b1b5325
Compare
Contributor
Author
mvines
approved these changes
Nov 6, 2020
CriesofCarrots
added
the
automerge
mergify Bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
* Add legacy stake-program handling * Strip out duplicative legacy code * Add feature for stake-program-fix * Feature-deploy new stake program * Expand comment (cherry picked from commit 1b1d9f6) # Conflicts: # runtime/src/builtins.rs # runtime/src/feature_set.rs
mergify Bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
* Add legacy stake-program handling * Strip out duplicative legacy code * Add feature for stake-program-fix * Feature-deploy new stake program * Expand comment (cherry picked from commit 1b1d9f6)
mergify Bot
added a commit
that referenced
this pull request
Nov 6, 2020
* Feature-gate stake program (#13394) * Add legacy stake-program handling * Strip out duplicative legacy code * Add feature for stake-program-fix * Feature-deploy new stake program * Expand comment (cherry picked from commit 1b1d9f6) # Conflicts: # runtime/src/builtins.rs # runtime/src/feature_set.rs * Fix conflicts Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upcoming stake-program fixes need to be feature-gated and released on testnet and mainnet-beta.
Summary of Changes
Needs rebase on #13403