SIMD-0297: Relax Invalid Nonced Transactions Constraint#297
Merged
Benhawkins18 merged 12 commits intoOct 13, 2025
Conversation
0x0ece
reviewed
Jun 6, 2025
Contributor
|
Doesn't this introduce a new DoS vector from a malicious leader? |
Contributor
topointon-jump
left a comment
There was a problem hiding this comment.
Looks good, could we just address my comments adding some clarity around some points? Thanks!
Contributor
Author
Thanks for feedback, updates in 57b1fb2 |
57b1fb2 to
f6d0d6b
Compare
Semen2322
approved these changes
Jul 22, 2025
sakridge
reviewed
Jul 22, 2025
106072a to
110d420
Compare
topointon-jump
approved these changes
Sep 29, 2025
sakridge
approved these changes
Oct 3, 2025
Contributor
Author
|
@Benhawkins18 this simd is ready for merge, thanks. |
apfitzge
suggested changes
Oct 3, 2025
apfitzge
reviewed
Oct 13, 2025
apfitzge
approved these changes
Oct 13, 2025
Contributor
apfitzge
left a comment
There was a problem hiding this comment.
The proposal looks good. It seems to be a temporary measure to deal with nonces in a move to supporting async - I still think it is valuable for us to determine a clear path to deleting nonces entirely. IMO leaving them in this state long-term is not a great idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.