v3.1: runtime: resolve compute budget in check_transaction() (backport of #9155)#9848
Merged
Conversation
* runtime: resolve compute budget in `check_transaction()` (cherry picked from commit abcf518)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.1 #9848 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 865 865
Lines 376114 376085 -29
=========================================
- Hits 313140 313083 -57
- Misses 62974 63002 +28 🚀 New features to boost your workflow:
|
Member
t-nelson
approved these changes
Jan 8, 2026
t-nelson
reviewed
Jan 8, 2026
buffalojoec
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
in implementing simd290 and simd297 it would be convenient if the only errors we had to handle in svm
validate_transaction_nonce_and_fee_payer()were the nonce and feepayer errors because we will have to propagate particular representations for those cases upwardsthe only error other than nonce/feepayer is unwrapping
Result<SVMTransactionExecutionAndFeeBudgetLimits>, constructed in runtimecheck_transactions()Summary of Changes
instead of delivering a malformed compute budget as its own error, transform it into a
Result<CheckedTransactionDetails>error in runtime. the only possible errors are insanitize_and_convert_to_compute_budget_limits(), checking that requested data and heap size values are sanethere are tests in several crates for a
DuplicateInstructionerror, which is not relevant to this pr. this type of error gets resolved much earlier inRuntimeTransaction<SanitizedVersionedTransaction>::try_from()and never makes it into a batchThis is an automatic backport of pull request #9155 done by Mergify.