runtime: resolve compute budget in check_transaction()

[2501babe]

Problem

in implementing simd290 and simd297 it would be convenient if the only errors we had to handle in svm validate_transaction_nonce_and_fee_payer() were the nonce and feepayer errors because we will have to propagate particular representations for those cases upwards

the only error other than nonce/feepayer is unwrapping Result<SVMTransactionExecutionAndFeeBudgetLimits>, constructed in runtime check_transactions()

Summary of Changes

instead of delivering a malformed compute budget as its own error, transform it into a Result<CheckedTransactionDetails> error in runtime. the only possible errors are in sanitize_and_convert_to_compute_budget_limits(), checking that requested data and heap size values are sane

there are tests in several crates for a DuplicateInstruction error, which is not relevant to this pr. this type of error gets resolved much earlier in RuntimeTransaction<SanitizedVersionedTransaction>::try_from() and never makes it into a batch

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (144249c) to head (bed5ddd).

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #9155     +/-   ##
=========================================
- Coverage    82.6%    82.6%   -0.1%     
=========================================
  Files         890      890             
  Lines      320911   320873     -38     
=========================================
- Hits       265364   265282     -82     
- Misses      55547    55591     +44     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[buffalojoec]

The changes lgtm, nice and clean! Just one question about the metrics.

[buffalojoec]

Is it worth incrementing error_counters.invalid_compute_budget here instead?

[2501babe]

it doesnt exist yet; we create TransactionErrorMetrics in svm load_and_execute_sanitized_transactions()

[buffalojoec]

It's in the function signature though.

https://github.com/anza-xyz/agave/pull/9155/files#diff-52fb4862bc04162ee94bd68b537a669a99a201e7897cdfc76b37f059cb7e91adR97

[2501babe]

oh i never noticed this before, it actually accumulates the svm ones into a parent in runtime. ill make that change, ty!

[buffalojoec]

Thanks!

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.