Add request timeout to network connection and configuration (close #836) #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Snowplow/Network/DefaultNetworkConnection.swift
matus-tomlein
added a commit
that referenced
this pull request
Feb 1, 2024
PR #869 --------- Co-authored-by: Daniel Gutiérrez Ayuso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #836
This PR builds on top of PR #837 to add timeout to
DefaultNetworkConnectionwhile considering the open comments.Additionally, this PR adds the
timeoutconfiguration to theNetworkConfigurationsimilar as it is on our Android tracker. It also sets the default timeout to 30 seconds to match the Android tracker setting.