Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The timeout is fixed and cannot be configured to a custom value #836

Closed
danigutierrezayuso opened this issue Oct 4, 2023 · 1 comment
Closed

The timeout is fixed and cannot be configured to a custom value #836

danigutierrezayuso opened this issue Oct 4, 2023 · 1 comment
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
6.0.0

Comments

@danigutierrezayuso
Copy link
Contributor

Describe the bug
The network timeout is fixed to the URLSession default (60 seconds) and cannot be configured from the outside.

Expected behavior
When configuring the Snowplow sdk you should be able to set a custom timeout for the network requests.
@danigutierrezayuso danigutierrezayuso added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Oct 4, 2023
@danigutierrezayuso
Copy link
Contributor Author

I've created this PR allowing this timeout config with a custom value (without any new tests): #837

@matus-tomlein matus-tomlein mentioned this issue Jan 30, 2024
Merged
matus-tomlein added a commit that referenced this issue Jan 31, 2024
@matus-tomlein @danigutierrezayuso
Add request timeout to network connection and configuration (close #836)
3982f61 
PR #869

---------

Co-authored-by: Daniel Gutiérrez Ayuso <[email protected]>
@matus-tomlein matus-tomlein added this to the 6.0.0 milestone Feb 1, 2024
@matus-tomlein matus-tomlein mentioned this issue Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@matus-tomlein @danigutierrezayuso