Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request timeout to network connection and configuration (close #836) #869

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Add request timeout to network connection and configuration (close #836) #869

merged 3 commits into from
Jan 31, 2024

Commits on Jan 30, 2024

  1. Add 'timeout' param to DefaultNetworkConnection 

    # Conflicts:
#	Sources/Snowplow/Network/DefaultNetworkConnection.swift
    @danigutierrezayuso @matus-tomlein
    danigutierrezayuso authored and matus-tomlein committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2904a74 View commit details
    Browse the repository at this point in the history

  2. Set default timeout to 30 seconds and make it configurable in Network… 

    …Configuration
    @matus-tomlein
    matus-tomlein committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7fe3cf0 View commit details
    Browse the repository at this point in the history

  3. Change timeout from var to let

    @matus-tomlein
    matus-tomlein committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7006e37 View commit details
    Browse the repository at this point in the history