Provide SigningService creation via owned String (#1114) #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
Jan 25, 2022
| @@ -42,3 +42,9 @@ impl SigningService { | |||
| SigningService(Cow::Borrowed(service)) | |||
| } | |||
| } | |||
|
|
|||
| impl From<String> for SigningService { | |||
There was a problem hiding this comment.
This looks great! Thanks!
jdisanti
approved these changes
Jan 25, 2022
rcoh
approved these changes
Jan 25, 2022
|
Don't worry about the PR Bot failures. If everything else passes, I'll get this merged and into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
SigningServicehas inner typeCow<'static, str>but does not allow creation with ownedString. This causes limitations in its functionality to users.#1114
Description
Implement
Fromtrait forSigningService.Testing
Code change is minimal. Testing not added, changes checked for compilation and functionally through playground as well as
cargo test.Checklist
[x] I have updated
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.