Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SigningService creation via owned String (#1114) #1120

Merged
merged 5 commits into from
Jan 25, 2022
Merged

Provide SigningService creation via owned String (#1114) #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ffda0b
Provide SigningService creation via owned String (#1114)
mchoicpe-amazon Jan 25, 2022
6945a0b
Merge branch 'main' into fix-1114
mchoicpe-amazon Jan 25, 2022
35d1443
Correct CHANGELOG.next.toml to include previous changes
mchoicpe-amazon Jan 25, 2022
b0d9dea
Merge branch 'fix-1114' of https://github.com/mchoicpe-amazon/smithy-…
mchoicpe-amazon Jan 25, 2022
42a80ab
Fetch and merge changes from CHANGELOG.next.toml
mchoicpe-amazon Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.next.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@ message = "SDK examples now come from [`awsdocs/aws-doc-sdk-examples`](https://g
references = ["smithy-rs#1118"]
meta = { "breaking" = false, "tada" = false, "bug" = false }
author = "jdisanti"

[[smithy-rs]]
message = "Provide SigningService creation via owned String"
mchoicpe-amazon marked this conversation as resolved.
Show resolved Hide resolved
references = ["smithy-rs#1114"]
meta = { "breaking" = false, "tada" = false, "bug" = false }
author = "mchoicpe-amazon"
6 changes: 6 additions & 0 deletions aws/rust-runtime/aws-types/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,9 @@ impl SigningService {
SigningService(Cow::Borrowed(service))
}
}

impl From<String> for SigningService {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

fn from(service: String) -> Self {
SigningService(Cow::Owned(service))
}
}