Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make possible to create a SigningService with an owned String #1114

Closed
jdisanti opened this issue Jan 25, 2022 · 1 comment
Closed

Make possible to create a SigningService with an owned String #1114

jdisanti opened this issue Jan 25, 2022 · 1 comment
Labels
customer-request good first issue Good for newcomers

Comments

@jdisanti
Copy link
Collaborator

The SigningService has an inner type of Cow<'static, str>, but no public way of constructing it with an owned value (there's only from_static). Another function or trait implementation should be added to be able to create it from String.
mchoicpe-amazon added a commit to mchoicpe-amazon/smithy-rs that referenced this issue Jan 25, 2022
@mchoicpe-amazon
Provide SigningService creation via owned String (smithy-lang#1114)
5ffda0b
@mchoicpe-amazon mchoicpe-amazon mentioned this issue Jan 25, 2022
Merged
jdisanti pushed a commit that referenced this issue Jan 25, 2022
@mchoicpe-amazon
Provide SigningService creation via owned String (#1114) (#1120)
e0f0193
@jdisanti
Copy link
Collaborator Author

This went out with smithy-rs 0.36.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdisanti