chore(gprc): bump up grpc-servicer version to 0.5.3 - #1443
CatherineSue merged 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesPackaging metadata update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Please indicate reasons for the bump in the PR and follow PR template. |
@CatherineSue Done. |
|
CI Failed because of network connectivity issue in rust setup. Not relevant to the version bump. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52c12d24a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hi @YouNeedCryDear, the DCO sign-off check has failed. All commits must include a To fix existing commits: # Sign off the last N commits (replace N with the number of unsigned commits)
git rebase HEAD~N --signoff
git push --force-with-leaseTo sign off future commits automatically:
|
6b4bab8 to
d6208cb
Compare
Signed-off-by: Arthur Cheng <arthur.cheng@oracle.com>
The grpc-servicer GetTokenizer depends on smg-grpc-proto 0.4.7 Signed-off-by: Arthur Cheng <arthur.cheng@oracle.com>
d6208cb to
a760907
Compare
Signed-off-by: Arthur Cheng <arthur.cheng@oracle.com> Co-authored-by: Chang Su <8605658+CatherineSue@users.noreply.github.com>
Description
Problem
The current
grpc-servicerrelease lacks the recently addedGetTokenizersupport for vLLM and SGLang, as well as the new servicer implementation for MLX.Solution
Bump the
smg-grpc-servicerversion to 0.5.3 to cut a new release on PyPI, making these features available for downstream integrations.Changes
smg-grpc-servicerversion from 0.5.2 to 0.5.3 ingrpc_servicer/pyproject.toml.Test Plan
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit
Summary by CodeRabbit