Skip to content

chore(grpc): release smg-grpc-proto 0.5.0 and smg-grpc-servicer 0.6.0 - #872

Merged
slin1237 merged 1 commit into
mainfrom
release/grpc-packages
Mar 23, 2026
Merged

slin1237 merged 1 commit into
mainfrom
release/grpc-packages

Conversation

@slin1237

@slin1237 slin1237 commented Mar 23, 2026 •

Copy link
Copy Markdown
Member

Description

Version bump to release the new vLLM GetModelInfo fields (#871) to PyPI. Required before building Docker images that pip install these packages.

Changes

  • smg-grpc-proto: 0.4.3 → 0.5.0 (new proto fields)
  • smg-grpc-servicer: 0.5.0 → 0.6.0 (new servicer logic, depends on proto ≥0.5.0)

Test Plan

  • release-grpc workflow triggers on merge (watches these pyproject.toml files)
  • Proto publishes first, then servicer (workflow handles ordering)
Checklist
  • Version bumps
  • Dependency constraint updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Summary by CodeRabbit

  • Chores
    • Bumped Python package versions: 0.4.3 → 0.4.4 and 0.5.0 → 0.5.1.
    • Raised the minimum required version of the shared gRPC proto dependency to 0.4.4.

@slin1237
slin1237 requested a review from CatherineSue as a code owner March 23, 2026 22:34
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@github-actions github-actions Bot added the dependencies Dependency updates label Mar 23, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on releasing new versions of the smg-grpc-proto and smg-grpc-servicer Python packages to PyPI. This update is crucial for integrating new vLLM GetModelInfo fields and is a prerequisite for building Docker images that rely on these packages.

Highlights

  • smg-grpc-proto Version Bump: The smg-grpc-proto package has been updated from version 0.4.3 to 0.5.0 to incorporate new vLLM GetModelInfo fields.
  • smg-grpc-servicer Version Bump: The smg-grpc-servicer package has been updated from version 0.5.0 to 0.6.0, reflecting new servicer logic.
  • Dependency Update: The smg-grpc-servicer package's dependency on smg-grpc-proto has been updated to require version >=0.5.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@coderabbitai

coderabbitai Bot commented Mar 23, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c327edd8-8860-4d3a-a6a9-a08aea928ee5

📥 Commits

Reviewing files that changed from the base of the PR and between 5fc899a and 07730af.

📒 Files selected for processing (2)
  • crates/grpc_client/python/pyproject.toml
  • grpc_servicer/pyproject.toml

📝 Walkthrough

Walkthrough

Updated Python package metadata: bumped version in crates/grpc_client/python/pyproject.toml from 0.4.3 → 0.4.4; bumped grpc_servicer/pyproject.toml from 0.5.0 → 0.5.1 and raised its smg-grpc-proto dependency constraint from >=0.4.2 → >=0.4.4.

Changes

Cohort / File(s) Summary
grpc_client Python package
crates/grpc_client/python/pyproject.toml
Package version bumped: 0.4.3 → 0.4.4. No other metadata or dependencies changed.
grpc_servicer package & dependency
grpc_servicer/pyproject.toml
Package version bumped: 0.5.0 → 0.5.1. Dependency constraint updated: smg-grpc-proto>=0.4.2 → smg-grpc-proto>=0.4.4.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly Related PRs

  • #611: Related gRPC pyproject version changes; touches smg-grpc-proto versioning similar to this PR.
  • #386: CI/workflow updates that react to changes in grpc_client/python/pyproject.toml (publishing/checks).
  • #610: Changes relocating package versioning into pyproject.toml, tied to how package versions are managed here.

Suggested Labels

grpc

Suggested Reviewers

  • CatherineSue
  • key4ng

Poem

🐰 I hopped through toml to tweak a line,
Bumped numbers small, kept changes fine.
Proto bounds nudged, versions in tune,
A little rabbit hums a release-time tune. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions releasing smg-grpc-proto 0.5.0 and smg-grpc-servicer 0.6.0, but the actual changes show smg-grpc-proto 0.4.4 and smg-grpc-servicer 0.5.1. Update the title to accurately reflect the actual version bumps: 'chore(grpc): release smg-grpc-proto 0.4.4 and smg-grpc-servicer 0.5.1' or verify the changeset matches the intended releases.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/grpc-packages

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the versions of the smg-grpc-proto and smg-grpc-servicer packages for a new release. The version of smg-grpc-proto is updated to 0.5.0, and smg-grpc-servicer is updated to 0.6.0 with its dependency on smg-grpc-proto correctly set to >=0.5.0. The changes are straightforward and align with the stated goal of the pull request. The version updates are correct, and I have no further feedback.

- smg-grpc-proto 0.4.3 → 0.4.4: new fields in vLLM GetModelInfoResponse
  (tokenizer_path, model_type, architectures, eos_token_ids, pad_token_id,
  bos_token_id, max_req_input_len) — backward compatible additive change
- smg-grpc-servicer 0.5.0 → 0.5.1: populate new vLLM model info fields
  from model_config and hf_config — backward compatible
- servicer dependency bumped to smg-grpc-proto>=0.4.4

Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
@slin1237
slin1237 force-pushed the release/grpc-packages branch from 5fc899a to 07730af Compare March 23, 2026 22:37
@slin1237
slin1237 merged commit 8a463a1 into main Mar 23, 2026
30 of 32 checks passed
@slin1237
slin1237 deleted the release/grpc-packages branch March 23, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants