Repository navigation
chore(grpc): release smg-grpc-proto 0.5.0 and smg-grpc-servicer 0.6.0 - #872
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on releasing new versions of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated Python package metadata: bumped version in Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request bumps the versions of the smg-grpc-proto and smg-grpc-servicer packages for a new release. The version of smg-grpc-proto is updated to 0.5.0, and smg-grpc-servicer is updated to 0.6.0 with its dependency on smg-grpc-proto correctly set to >=0.5.0. The changes are straightforward and align with the stated goal of the pull request. The version updates are correct, and I have no further feedback.
- smg-grpc-proto 0.4.3 → 0.4.4: new fields in vLLM GetModelInfoResponse (tokenizer_path, model_type, architectures, eos_token_ids, pad_token_id, bos_token_id, max_req_input_len) — backward compatible additive change - smg-grpc-servicer 0.5.0 → 0.5.1: populate new vLLM model info fields from model_config and hf_config — backward compatible - servicer dependency bumped to smg-grpc-proto>=0.4.4 Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
5fc899a to
07730af
Compare
Description
Version bump to release the new vLLM GetModelInfo fields (#871) to PyPI. Required before building Docker images that
pip installthese packages.Changes
smg-grpc-proto: 0.4.3 → 0.5.0 (new proto fields)smg-grpc-servicer: 0.5.0 → 0.6.0 (new servicer logic, depends on proto ≥0.5.0)Test Plan
Checklist
Summary by CodeRabbit