chore(grpc): release smg-grpc-proto 0.4.8 - #1562
Conversation
|
Warning Review limit reached
More reviews will be available in 10 minutes and 18 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version of smg-grpc-proto from 0.4.7 to 0.4.8 in crates/grpc_client/python/pyproject.toml. It also updates grpc_servicer/pyproject.toml to bump its version to 0.5.4 and updates its dependency on smg-grpc-proto to >=0.4.8. I have no feedback to provide as there are no review comments.
github-actions
Bot
added
dependencies
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
PR #1462 added `default_sampling_params_json` to the SGLang/vLLM/MLX gRPC GetModelInfo responses, and smg-grpc-servicer 0.5.3 publishes that field. The latest smg-grpc-proto on PyPI (0.4.7) predates the proto change, so installing servicer 0.5.3 against proto 0.4.7 crashes when GetModelInfo runs. Bump smg-grpc-proto to 0.4.8 to cut a new release that includes the field. Servicer 0.5.3's existing `smg-grpc-proto>=0.4.7` constraint will resolve to 0.4.8 for new installs, so no servicer bump is needed. Fixes #1561 Signed-off-by: Chang Su <8605658+CatherineSue@users.noreply.github.com>
8172e49 to
421234f
Compare
CatherineSue
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 421234f1e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Description
Problem
PR #1462 added a
default_sampling_params_jsonfield to the gRPCGetModelInforesponses for SGLang/vLLM/MLX, andsmg-grpc-servicer0.5.3 (released by #1443) publishes that field insglang/servicer.py(and the vLLM/TokenSpeed servicers).The latest
smg-grpc-protoon PyPI (0.4.7) predates the proto change, so installingsmg-grpc-servicer>=0.5.3againstsmg-grpc-proto==0.4.7crashes whenGetModelInforuns.Fixes #1561.
Solution
Bump
smg-grpc-prototo 0.4.8 to cut a new release that includes the field. Servicer 0.5.3's existingsmg-grpc-proto>=0.4.7constraint already resolves to the latest matching proto, so new installs will pick up 0.4.8 automatically — no servicer bump needed.Changes
crates/grpc_client/python/pyproject.toml: smg-grpc-proto 0.4.7 → 0.4.8Test Plan
release-grpc.yml) succeeds on merge to mainChecklist
cargo +nightly fmtpasses (no Rust changes)cargo clippy --all-targets --all-features -- -D warningspasses (no Rust changes)