Repository navigation
ci: apply change detection to pull_request_target events - #1104
Conversation
The detect-changes job already runs for pull_request_target (fork PRs), but the downstream e2e job conditions only checked for pull_request, causing all engines to run unconditionally on fork PRs regardless of which paths were modified. This wastes GPU time when a fork PR only touches one engine's code. Add pull_request_target to the event_name check in all 7 e2e job conditions so path-based filtering applies equally to fork PRs. Signed-off-by: ai-jz <ai-jz@users.noreply.github.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated job-level conditional statements in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit b776668. Reverting as part of rolling back the ci-approved fork PR trigger added in #1095. Once the pull_request_target workflow trigger is removed, these e2e job conditions referring to `github.event_name != 'pull_request_target'` become dead code and would never evaluate, so they are reverted together. Refs: #1095, #1104 Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
Summary
PR #1095 (commit 381c5f6) implemented change detection for
ci-approvedfork PRs by addingpull_request_targetto thedetect-changesjob. However, the 7 downstream e2e job conditions only check filter outputs forpull_requestevents. This PR extends them to also check forpull_request_target, soci-approvedfork PRs skip unrelated e2e categories — same as direct PRs.Changes
Added
&& github.event_name != 'pull_request_target'to all 7 e2e job conditions so that path-based change detection applies equally toci-approvedfork PRs.Context
PR #1095 (commit 381c5f6) implemented change detection for
ci-approvedfork PRs by addingpull_request_targetto the workflow triggers, updatingdetect-changesto run for both event types, and addingci-gatefor label checking. This PR extends the same approach to the 7 downstream e2e job conditions.cc @slin1237 — this extends your work in #1095.
Test plan
check yamlhook)ci-approvedfork PR that touches only one category's pathsSummary by CodeRabbit