Repository navigation
ci: remove check-ci gate, drop run-ci label, skip e2e for Dependabot - #550
Conversation
- Delete .github/actions/check-ci/ (buggy and redundant with GitHub's native fork approval) - Remove check-ci job and all needs/if references from pr-test-rust.yml and 5 benchmark workflows - Remove 'labeled' trigger type (no longer needed without run-ci label) - Skip gateway-e2e and go-bindings-e2e for Dependabot PRs (no repo secrets available) Signed-off-by: Chang Su <chang.s.su@oracle.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the continuous integration (CI) workflow by addressing issues with a custom CI gating mechanism and optimizing Dependabot PRs. It eliminates a buggy custom action, removes a redundant label, and intelligently skips e2e tests for Dependabot to prevent unnecessary failures, ultimately making the CI process more efficient and reliable. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves the check-ci GitHub Action that gated CI execution based on pull_request context, actor identity, and run-ci labels. Updates six workflow files (five benchmark workflows and pr-test-rust.yml) to eliminate this centralized gate, replacing it with simplified repository-specific conditions or direct job dependencies. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the CI/CD pipeline by removing a buggy custom GitHub action (check-ci) and replacing it with GitHub's native functionality for gating pull requests from external collaborators. It also intelligently skips end-to-end tests for Dependabot PRs, which lack the necessary secrets to run them successfully. These changes simplify the CI configuration, remove the need for manual workarounds like the run-ci label, and make the process more robust and maintainable.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2069daede2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
Description
Problem
The custom
check-ciaction has bugs — it usesgithub.event.pull_request.author_associationwhich returns the PR author's association, not the event actor's. This means repo owners/members triggering CI on behalf of external PRs (e.g. Dependabot) still get gated. Therun-cilabel was a workaround but added manual overhead.Additionally, Dependabot PRs only have access to Dependabot-scoped secrets (not repo secrets), so e2e tests that require
HF_TOKEN,OPENAI_API_KEY, etc. will always fail.Solution
check-cientirely — rely on GitHub's native "Require approval for outside collaborators" setting for fork PR gatingrun-cilabel — no longer needed withoutcheck-ciChanges
.github/actions/check-ci/action.ymlcheck-cijob and allneeds/ifreferences frompr-test-rust.ymlcheck-cijob from 5 benchmark workflows (benchmark-tokenizer,benchmark-radix-tree,benchmark-tool-parser,benchmark-manual-policy,benchmark-request-processing)labeledfrom PR trigger types (no longer needed withoutrun-cilabel)if: github.actor != 'dependabot[bot]'togateway-e2eandgo-bindings-e2ejobsfinishjob to removecheck-cidependencyTest Plan
finishpasses (skipped != failure)Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesManual setup required
After merging, enable "Require approval for all outside collaborators" in repo Settings > Actions > General > Fork pull request workflows.
Summary by CodeRabbit
Release Notes