Skip to content

chore(tui): remove smg-tui crate and related dependencies - #1718

Merged
lightseek-bot merged 1 commit into
mainfrom
chore/remove-tui
Jun 13, 2026
Merged

lightseek-bot merged 1 commit into
mainfrom
chore/remove-tui

Conversation

@key4ng

@key4ng key4ng commented Jun 13, 2026 •

Copy link
Copy Markdown
Member

Description

Problem

The smg-tui crate is too heavy to live alongside the gateway in this repo. It is being moved to a standalone repository.

Solution

Remove the smg-tui crate and all of its references and dependencies from the workspace.

Changes

  • Delete the tui/ crate (smg-tui) — all source, README, and demo assets
  • Remove the tui workspace member and the smg-tui workspace dependency from Cargo.toml
  • Drop the tui/** path filter from the Rust PR CI workflow (pr-test-rust.yml)
  • Remove the incidental TUI mention from docs/reference/metrics.md
  • Remove the now-stale ratatui entry from the codespell ignore list (.pre-commit-config.yaml)

ratatui and crossterm were used only by the TUI and are pruned from the lockfile. No other crate depended on smg-tui.

Test Plan

  • cargo +nightly fmt --all -- --check — clean
  • cargo clippy --all-targets --all-features -- -D warnings — zero warnings
  • cargo test --workspace — all pass, 0 failures
  • Repo-wide grep confirms zero remaining smg-tui / ratatui / crossterm references
Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Summary by CodeRabbit

  • Removed Features

    • Removed the terminal user interface (TUI) dashboard and all TUI-driven functionality.
  • Chores

    • Updated CI/workflow triggers and workspace configuration to reflect the TUI removal.
    • Updated documentation to stop referencing the TUI and describe metrics endpoint as used by dashboards.

@github-actions github-actions Bot added documentation Improvements or additions to documentation dependencies Dependency updates ci CI/CD configuration changes labels Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9921991c-6c12-4d42-876f-9b901bae5ea5

📥 Commits

Reviewing files that changed from the base of the PR and between 64c1c5c and 3bec06e.

⛔ Files ignored due to path filters (2)
  • tui/assets/add-worker.gif is excluded by !**/*.gif
  • tui/assets/tui-demo.gif is excluded by !**/*.gif
📒 Files selected for processing (30)
  • .github/workflows/pr-test-rust.yml
  • .pre-commit-config.yaml
  • Cargo.toml
  • docs/reference/metrics.md
  • tui/Cargo.toml
  • tui/README.md
  • tui/src/app.rs
  • tui/src/chat.rs
  • tui/src/client.rs
  • tui/src/event.rs
  • tui/src/lib.rs
  • tui/src/main.rs
  • tui/src/state.rs
  • tui/src/types.rs
  • tui/src/ui/action_menu.rs
  • tui/src/ui/chat.rs
  • tui/src/ui/detail.rs
  • tui/src/ui/dialog.rs
  • tui/src/ui/filter.rs
  • tui/src/ui/footer.rs
  • tui/src/ui/help.rs
  • tui/src/ui/logs.rs
  • tui/src/ui/mod.rs
  • tui/src/ui/models.rs
  • tui/src/ui/pulse.rs
  • tui/src/ui/sparkline.rs
  • tui/src/ui/stats_bar.rs
  • tui/src/ui/tabs.rs
  • tui/src/ui/theme.rs
  • tui/src/ui/workers.rs
💤 Files with no reviewable changes (27)
  • tui/src/ui/dialog.rs
  • tui/src/lib.rs
  • tui/Cargo.toml
  • tui/src/ui/sparkline.rs
  • tui/src/ui/models.rs
  • tui/src/ui/help.rs
  • tui/src/ui/theme.rs
  • tui/src/ui/logs.rs
  • tui/src/state.rs
  • tui/src/event.rs
  • tui/README.md
  • tui/src/ui/footer.rs
  • tui/src/app.rs
  • tui/src/ui/mod.rs
  • tui/src/ui/tabs.rs
  • tui/src/ui/chat.rs
  • tui/src/ui/stats_bar.rs
  • tui/src/ui/workers.rs
  • tui/src/ui/filter.rs
  • tui/src/client.rs
  • tui/src/chat.rs
  • tui/src/ui/detail.rs
  • tui/src/ui/action_menu.rs
  • tui/src/types.rs
  • tui/src/ui/pulse.rs
  • tui/src/main.rs
  • .github/workflows/pr-test-rust.yml

📝 Walkthrough

Walkthrough

Remove the tui crate from the workspace and workspace dependencies, update CI detect-changes path filters to stop triggering on TUI files and include Rust/CI paths, and adjust codespell config and metrics docs wording accordingly.

Changes

TUI Crate Removal & Workspace Updates

Layer / File(s) Summary
Workspace membership and dependency
Cargo.toml
Removed tui from workspace members and removed the [workspace.dependencies] alias smg-tui pointing to tui.
CI detect-changes paths
.github/workflows/pr-test-rust.yml
Removed tui/** from rust-ci paths and added Rust/CI-relevant globs: .cargo/**, ./.github/actions/setup-rust/**, scripts/ci_install_rust.sh, the workflow file itself, and specific WASM example hook paths.
Tooling: codespell config
.pre-commit-config.yaml
Removed ratatui from the codespell hook -L exclusion list.
Docs: metrics endpoint wording
docs/reference/metrics.md
Reworded /ws/metrics description to remove explicit TUI mention, describing usage by dashboards requiring live metric state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

tests

Suggested reviewers

  • CatherineSue
  • slin1237

Poem

🐰
Hop, little crate, off the shelf I sweep,
Workspace lighter, the changes run deep.
CI paths trimmed, docs tidy and neat,
Pre-commit cleaned — a small, quiet feat.
Carrots for reviewers — swift paws, quick peep.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(tui): remove smg-tui crate and related dependencies' directly and accurately describes the main change: removal of the TUI crate and its dependencies from the workspace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-tui

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request completely removes the smg-tui (Shepherd Model Gateway Terminal User Interface) crate and its associated source code, configurations, and documentation references from the workspace. There are no review comments to address, so I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean crate removal — all workspace, CI, docs, and codespell references properly cleaned up. No stale smg-tui/ratatui/crossterm references remain in the repo. LGTM.

The TUI is being moved to a standalone repository as it is too heavy to
live alongside the gateway. This removes:

- the tui/ crate (smg-tui) and its assets
- the workspace member and smg-tui workspace dependency
- the tui/** path filter in the Rust PR CI workflow
- the incidental TUI mention in the metrics docs
- the now-stale ratatui codespell ignore entry

ratatui and crossterm were used only by the TUI and are pruned from the
lockfile. No other crate depended on smg-tui.

Signed-off-by: key4ng <rukeyang@gmail.com>
@key4ng
key4ng force-pushed the chore/remove-tui branch from 64c1c5c to 3bec06e Compare June 13, 2026 21:06
@lightseek-bot
lightseek-bot merged commit fd330b1 into main Jun 13, 2026
39 of 42 checks passed
@lightseek-bot
lightseek-bot deleted the chore/remove-tui branch June 13, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes dependencies Dependency updates documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants