Repository navigation
chore(tui): remove smg-tui crate and related dependencies - #1718
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (30)
💤 Files with no reviewable changes (27)
📝 WalkthroughWalkthroughRemove the ChangesTUI Crate Removal & Workspace Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request completely removes the smg-tui (Shepherd Model Gateway Terminal User Interface) crate and its associated source code, configurations, and documentation references from the workspace. There are no review comments to address, so I have no further feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The TUI is being moved to a standalone repository as it is too heavy to live alongside the gateway. This removes: - the tui/ crate (smg-tui) and its assets - the workspace member and smg-tui workspace dependency - the tui/** path filter in the Rust PR CI workflow - the incidental TUI mention in the metrics docs - the now-stale ratatui codespell ignore entry ratatui and crossterm were used only by the TUI and are pruned from the lockfile. No other crate depended on smg-tui. Signed-off-by: key4ng <rukeyang@gmail.com>
Description
Problem
The
smg-tuicrate is too heavy to live alongside the gateway in this repo. It is being moved to a standalone repository.Solution
Remove the
smg-tuicrate and all of its references and dependencies from the workspace.Changes
tui/crate (smg-tui) — all source, README, and demo assetstuiworkspace member and thesmg-tuiworkspace dependency fromCargo.tomltui/**path filter from the Rust PR CI workflow (pr-test-rust.yml)docs/reference/metrics.mdratatuientry from the codespell ignore list (.pre-commit-config.yaml)ratatuiandcrosstermwere used only by the TUI and are pruned from the lockfile. No other crate depended onsmg-tui.Test Plan
cargo +nightly fmt --all -- --check— cleancargo clippy --all-targets --all-features -- -D warnings— zero warningscargo test --workspace— all pass, 0 failuressmg-tui/ratatui/crosstermreferencesChecklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit
Removed Features
Chores