Skip to content

Conversation

@dskloetc
Copy link
Contributor

https://smartcontract-it.atlassian.net/browse/OPDATA-3889

Description

The files we download over SFTP from FTSE are not UTF-8 encoded but rather Latin1 encoded.
This matters because there is a "Ⓡ" (registered trademark) symbol in the Russell index names.
We also have one such file in the fixtures directory but we currently read it with utf-8 encoding.
This means that in the unit tests we need to expect "�" instead of "Ⓡ".
I realized this when trying to add integration tests which failed when using the utf-8 decoded fixtures.

Changes

  1. Decode fixture files with latin1 encoding.
  2. Replace "�" with "Ⓡ" in tests.

Steps to Test

yarn test packages/sources/ftse-sftp/test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2025

⚠️ No Changeset found

Latest commit: bca2985

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dskloetc dskloetc marked this pull request as ready for review September 19, 2025 09:10
@dskloetc dskloetc enabled auto-merge (squash) September 19, 2025 09:13
@dskloetc dskloetc requested a review from a team September 19, 2025 09:13
@dskloetc dskloetc merged commit 99cd639 into main Sep 19, 2025
17 checks passed
@dskloetc dskloetc deleted the kloet/ftse-latin1 branch September 19, 2025 09:29
@dskloetc dskloetc mentioned this pull request Sep 19, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants