OPDATA-3889: FTSE: Use latin1 encoding #4035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/OPDATA-3889
Description
The files we download over SFTP from FTSE are not UTF-8 encoded but rather Latin1 encoded.
This matters because there is a "Ⓡ" (registered trademark) symbol in the Russell index names.
We also have one such file in the
fixturesdirectory but we currently read it withutf-8encoding.This means that in the unit tests we need to expect "�" instead of "Ⓡ".
I realized this when trying to add integration tests which failed when using the
utf-8decoded fixtures.Changes
latin1encoding.Steps to Test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file or update the soak testing blacklist.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.