Skip to content

OPDATA-3889: FTSE: Use latin1 encoding #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dskloetc merged 1 commit into from
Sep 19, 2025
Merged

OPDATA-3889: FTSE: Use latin1 encoding #4035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sources/ftse-sftp/test/fixtures/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'path'

// Helper function to read fixture files
export function readFixtureFile(filename: string): string {
return fs.readFileSync(path.join(__dirname, filename), 'utf-8')
return fs.readFileSync(path.join(__dirname, filename), 'latin1')
}

// Raw CSV fixture data
Expand All @@ -20,7 +20,7 @@ export const expectedFtseData = {
}

export const expectedRussellData = {
indexName: 'Russell 1000� Index',
indexName: 'Russell 1000® Index',
close: 3547.4,
}

Expand Down
12 changes: 6 additions & 6 deletions packages/sources/ftse-sftp/test/unit/parsing/russell.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ describe('RussellDailyValuesParser', () => {
let parser: RussellDailyValuesParser

beforeEach(() => {
parser = new RussellDailyValuesParser('Russell 1000� Index')
parser = new RussellDailyValuesParser('Russell 1000® Index')
})

describe('parse', () => {
Expand Down Expand Up @@ -39,7 +39,7 @@ Russell 1000® Index,Some Value`
"As of August 27, 2025",,,,,,,,"Last 5 Trading Days",,,,"1 Year Ending",,
,,,,,,,,"Closing Values",,,,"Closing Values",,
,"Open","High","Low","Close","Net Chg","% Chg","High","Low","Net Chg","% Chg","High","Low","Net Chg","% Chg"
Russell 1000� Index,3538.25,3550.79,3534.60,,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28`
Russell 1000® Index,3538.25,3550.79,3534.60,,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28`

await expect(parser.parse(csvWithNullValues)).rejects.toThrow(
'Empty values found in required columns: Close',
Expand Down Expand Up @@ -67,8 +67,8 @@ Russell 2000® Index,1234.56,1245.67,1230.45,1240.00,5.44,0.44,1245.67,1200.00,3
"As of August 27, 2025",,,,,,,,"Last 5 Trading Days",,,,"1 Year Ending",,
,,,,,,,,"Closing Values",,,,"Closing Values",,
,"Open","High","Low","Close","Net Chg","% Chg","High","Low","Net Chg","% Chg","High","Low","Net Chg","% Chg"
Russell 1000� Index,3538.25,3550.79,3534.60,3547.40,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28
Russell 1000� Index,3538.25,3550.79,3534.60,3547.50,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28`
Russell 1000® Index,3538.25,3550.79,3534.60,3547.40,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28
Russell 1000® Index,3538.25,3550.79,3534.60,3547.50,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28`

await expect(parser.parse(csvWithDuplicateRussell)).rejects.toThrow(
'Multiple matching Russell index records found, expected only one',
Expand All @@ -83,12 +83,12 @@ Russell 1000� Index,3538.25,3550.79,3534.60,3547.50,9.16,0.26,3547.40,3483.25,
"As of August 27, 2025",,,,,,,,"Last 5 Trading Days",,,,"1 Year Ending",,
,,,,,,,,"Closing Values",,,,"Closing Values",,
,"Open","High","Low","Close","Net Chg","% Chg","High","Low","Net Chg","% Chg","High","Low","Net Chg","% Chg"
Russell 1000� Index,3538.25,3550.79,3534.60,3547.40,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28
Russell 1000® Index,3538.25,3550.79,3534.60,3547.40,9.16,0.26,3547.40,3483.25,51.20,1.46,3547.40,2719.99,496.76,16.28
Russell 2000® Index,1234.56,1245.67,1230.45,1240.00,5.44,0.44
XXXXXXXX`

const { parsedData } = await parser.parse(csvWithInconsistentColumns)
expect(parsedData.indexName).toBe('Russell 1000� Index')
expect(parsedData.indexName).toBe('Russell 1000® Index')
expect(parsedData.close).toBe(3547.4)
})
})
Expand Down
Loading