Add Gauge For CheckMySQL Running#11524
Merged
GuptaManan100 merged 2 commits intovitessio:mainfrom Oct 20, 2022
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
systay
reviewed
Oct 20, 2022
systay
approved these changes
Oct 20, 2022
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 16, 2022
* feat: add gauge for checkMySQL running Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix data race by converting bool to atomic bool Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
Feb 19, 2023
* feat: add gauge for checkMySQL running Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix data race by converting bool to atomic bool Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
3 tasks
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
Jun 29, 2023
* feat: add gauge for checkMySQL running Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix data race by converting bool to atomic bool Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have been seeing a failure of
DemotePrimarywherein it just gets stuck indefinitely. The failure was traced to a call to acquiring a lock which was held by theCheckMySQLfunction which too is stuck indefinitely. This PR aims to add a gauge which tells us ifCheckMySQLis running or not. If the gauge is constantly 1 for more than 10 minutes, then it is an indication that something is wrong and we can take a look.Related Issue(s)
Checklist
Deployment Notes