Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria labels to toolbar #3639

Closed

Conversation

clairefields15
Copy link
Contributor

@clairefields15 clairefields15 commented Aug 25, 2022

Adds aria-labels to improve the accessibility of toolbar elements and color picker dropdowns. Some existing unit tests had to be tweaked in order to add these aria-labels to the html markup but all tests pass.
Screen Shot 2022-08-25 at 7 44 48 AM

addresses these issues:
#3360
#3320
#2038

@clairefields15 clairefields15 changed the title Story/add aria labels Add aria labels to toolbar Aug 25, 2022
@olsonjb
Copy link

olsonjb commented Aug 30, 2022

@jhchen My team is interested in this one and it looks like you're the one with power to review around here - I'd love to see this one approved!

@clairefields15
Copy link
Contributor Author

@luin looks like you've merged a few PRs recently, anything I can do to get this one moved along?

@joostverdoorn
Copy link

Would also love to see this happen! Anything I can do to help this? @luin

@ewalpole
Copy link

@clairefields15 I would love to see this merged but it looks like all of the labels are just English (maybe I am not understanding how it works??), I would need to be able to translate this to about 20 different languages in production so any idea on the best way to accomplish this? I can look at contributing as well.

@renoth
Copy link

renoth commented Apr 1, 2023

I do not understand why this very useful and simple PR did not get merged yet, it adresses one of the most glaring issues with this editor that prevents our organisation from using it.

@ymushinsky-ms
Copy link

ymushinsky-ms commented May 16, 2023

@clairefields15 hi, I am also looking for this functionality and appreciate the work you've done here, could you please fix the current conflicts for the merge? I'll try reaching out to @jhchen, @luin by email as well to try and get this merged :)

@TimaRebesh
Copy link

This issue is almost a year old. Are you going to solve it in the near future? Please, we are still waiting for

@luin
Copy link
Member

luin commented Aug 25, 2023

Sorry for the delay. The commit is modified cherry-picked into the develop branch. It provides a basic support for aria-label but you are able to customize it by passing a HTML container as toolbar options as documented here. Thanks for the contribution!

I'm closing this now. Feel free to open new tickets if there are anything unaddressed.

@luin luin closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants